Provider: Signing #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provider/src/iosMain/kotlin/at/asitplus/crypto/provider/os/IOSKeychainProvider.kt
Outdated
Show resolved
Hide resolved
provider/src/iosMain/kotlin/at/asitplus/crypto/provider/os/IOSKeychainProvider.kt
Outdated
Show resolved
Hide resolved
provider/src/androidMain/kotlin/at/asitplus/crypto/provider/os/AndroidKeyStoreProvider.kt
Outdated
Show resolved
Hide resolved
provider/src/androidMain/kotlin/at/asitplus/crypto/provider/os/AndroidKeyStoreProvider.kt
Outdated
Show resolved
Hide resolved
provider/src/androidMain/kotlin/at/asitplus/crypto/provider/os/AndroidKeyStoreProvider.kt
Outdated
Show resolved
Hide resolved
provider/src/commonMain/kotlin/at/asitplus/crypto/provider/os/TPMSigningProvider.kt
Outdated
Show resolved
Hide resolved
provider/src/commonMain/kotlin/at/asitplus/crypto/provider/os/TPMSigningProvider.kt
Outdated
Show resolved
Hide resolved
provider/src/iosMain/kotlin/at/asitplus/crypto/provider/os/IOSKeychainProvider.kt
Outdated
Show resolved
Hide resolved
provider/src/iosMain/kotlin/at/asitplus/crypto/provider/os/IOSKeychainProvider.kt
Outdated
Show resolved
Hide resolved
provider/src/iosMain/kotlin/at/asitplus/crypto/provider/os/IOSKeychainProvider.kt
Outdated
Show resolved
Hide resolved
iaik-jheher
commented
Aug 22, 2024
provider/src/commonMain/kotlin/at/asitplus/crypto/provider/os/SigningProvider.kt
Outdated
Show resolved
Hide resolved
provider/src/iosMain/kotlin/at/asitplus/crypto/provider/os/IosKeychainProvider.kt
Outdated
Show resolved
Hide resolved
iaik-jheher
commented
Aug 22, 2024
provider/src/commonMain/kotlin/at/asitplus/crypto/provider/os/Attestation.kt
Outdated
Show resolved
Hide resolved
iaik-jheher
force-pushed
the
feature/signer-provider
branch
from
c4c2a4f
to
6f5c8c4
Compare
This reverts commit 706959d.
JesusMcCloud
requested changes
Sep 3, 2024
supreme/src/commonMain/kotlin/at/asitplus/signum/supreme/SignatureResult.kt
Outdated
Show resolved
Hide resolved
| } | ||
| val SignatureResult.isSuccess get() = (this is SignatureResult.Success) | ||
| /** Retrieves the contained signature, asserting it exists. If it does not exist, throws the contained problem. */ | ||
| val SignatureResult.signature: CryptoSignature get() = when (this) { |
There was a problem hiding this comment.
Annotate with @throws for good measure
There was a problem hiding this comment.
can't, build breaks on ios
supreme/src/commonMain/kotlin/at/asitplus/signum/supreme/SignatureResult.kt
Outdated
Show resolved
Hide resolved
supreme/src/iosMain/kotlin/at/asitplus/signum/supreme/os/IosKeychainProvider.kt
Show resolved
Hide resolved
JesusMcCloud
requested changes
Sep 3, 2024
| #### Platform Signers | ||
|
|
||
| On Android and iOS, signers using the systems' secure key storage can be retrieved. | ||
| To do this, use `PlatformSigningProvider` (in common code), or interact with `AndroidKeystoreProvider`/`IosKeychainProvider` (in platform-specific code). |
There was a problem hiding this comment.
JKS signer is not a PlatformSigningProvider right now
This reverts commit becb46f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.