Add todos for other branch

a-sit-plus · Oct 7, 2024 · dac98f6 · dac98f6
1 parent 9b4d4a1
commit dac98f6
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/RqesWalletService.kt b/vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/RqesWalletService.kt
@@ -30,6 +30,7 @@ class RqesWalletService(
 
     /**
      * TODO: could also use [Document] instead of [CscDocumentDigest], also [credential_id] instead of [SAD]
+     * TODO implement [CredentialInfo] dataclass + hand over here
      */
     suspend fun createSignDocRequestParameters(rqesRequest: SignatureRequestParameters, sad: String): CSCSignatureRequestParameters =
         SignDocParameters(
@@ -44,14 +45,17 @@ class RqesWalletService(
             responseUri = this.redirectUrl, //TODO double check
         )
 
+
+    //TODO implement [CredentialInfo] dataclass + hand over here
     suspend fun createSignHashRequestParameters(
         rqesRequest: SignatureRequestParameters,
         credentialId: String,
         sad: String,
     ): CSCSignatureRequestParameters = SignHashParameters(
         credentialId = credentialId,
         sad = sad,
-        hashes = rqesRequest.documentDigests.map { it.hash }
+        hashes = rqesRequest.documentDigests.map { it.hash },
+        signAlgoOid = X509SignatureAlgorithm.ES256.oid
     )
 
 }