Feature/signature services #127
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodh
requested changes
Sep 16, 2024
dif-data-classes/src/commonMain/kotlin/at/asitplus/dif/rqes/CollectionEntries/Document.kt
Outdated
Show resolved
Hide resolved
dif-data-classes/src/commonMain/kotlin/at/asitplus/dif/rqes/CollectionEntries/Document.kt
Outdated
Show resolved
Hide resolved
dif-data-classes/src/commonMain/kotlin/at/asitplus/dif/rqes/CollectionEntries/Document.kt
Outdated
Show resolved
Hide resolved
dif-data-classes/src/commonMain/kotlin/at/asitplus/dif/rqes/CollectionEntries/Document.kt
Outdated
Show resolved
Hide resolved
dif-data-classes/src/commonMain/kotlin/at/asitplus/dif/rqes/CollectionEntries/Document.kt
Outdated
Show resolved
Hide resolved
n0900
had a problem deploying
to
github-pages
GitHub Actions
Failure
n0900
had a problem deploying
to
github-pages
GitHub Actions
Failure
n0900
had a problem deploying
to
github-pages
GitHub Actions
Failure
n0900
had a problem deploying
to
github-pages
GitHub Actions
Failure
n0900
had a problem deploying
to
github-pages
GitHub Actions
Failure
n0900
had a problem deploying
to
github-pages
GitHub Actions
Failure
n0900
had a problem deploying
to
github-pages
GitHub Actions
Failure
n0900
force-pushed
the
feature/signatureServices
branch
from
f5339f9
to
fb932fe
Compare
|
Rebase to #131 |
n0900
force-pushed
the
feature/signatureServices
branch
from
fcbb39d
to
c211cc1
Compare
nodh
requested changes
Oct 10, 2024
dif-data-classes/src/commonMain/kotlin/at/asitplus/dif/rqes/CollectionEntries/Document.kt
Outdated
Show resolved
Hide resolved
dif-data-classes/src/commonMain/kotlin/at/asitplus/dif/rqes/CollectionEntries/Document.kt
Outdated
Show resolved
Hide resolved
dif-data-classes/src/commonMain/kotlin/at/asitplus/dif/rqes/CollectionEntries/Document.kt
Outdated
Show resolved
Hide resolved
dif-data-classes/src/commonMain/kotlin/at/asitplus/dif/rqes/CollectionEntries/Document.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/at/asitplus/dif/rqes/CollectionEntries/DocumentDigestEntries/CscDocumentDigest.kt
Outdated
Show resolved
Hide resolved
| @@ -79,6 +81,7 @@ sealed class AuthorizationDetails { | |||
| * Credential Configuration in the [IssuerMetadata.supportedCredentialConfigurations]. The Wallet MUST use these | |||
| * identifiers together with an Access Token in subsequent Credential Requests. | |||
| */ | |||
| // TODO is required in OID4VCI! | |||
There was a problem hiding this comment.
For uc5 we get this after credential enrollment but this is out of scope for UC5 spec as well as CSC spec...
| @@ -15,6 +15,7 @@ data class CredentialRequestParameters( | |||
| * specific parameters such as those defined in Appendix A MUST NOT be present | |||
| */ | |||
| @SerialName("credential_identifier") | |||
| // TODO Update | |||
openid-data-classes/src/commonMain/kotlin/at/asitplus/openid/TokenResponseParameters.kt
Outdated
Show resolved
Hide resolved
openid-data-classes/src/commonMain/kotlin/at/asitplus/openid/rqes/RqesRequest.kt
Outdated
Show resolved
Hide resolved
| import at.asitplus.wallet.lib.oauth2.OAuth2Client | ||
| import com.benasher44.uuid.uuid4 | ||
|
|
||
| class RqesWalletService( |
There was a problem hiding this comment.
Unused class ... please use in tests
Extend RequestParsing to SignatureRequests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds remaining necessary data classes for the proposed UC5 remote signature flow.
This should finish the implementation of the OAuth2/CSC portion of the process.
Does not (yet) include OIDVCI extensions. Does not include any
credential/infodata classes or logic defined by CSCHelper classes also still rough.