Feature/rqes module #147
Open
Feature/rqes module #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodh
requested changes
Oct 17, 2024
|
|
||
| commonTest { | ||
| dependencies { | ||
| implementation("at.asitplus.wallet:eupidcredential:${VcLibVersions.eupidcredential}") |
|
|
||
| jvmMain { | ||
| dependencies { | ||
| implementation(signum.bcpkix.jdk18on) |
| } | ||
| } | ||
| } | ||
| //REMOVE ME AFTER REBRANDED ARTIFACT HAS BEEN PUBLISHED |
| @@ -32,6 +32,8 @@ kotlin { | |||
| commonMain { | |||
| dependencies { | |||
| api(project(":dif-data-classes")) | |||
| api(project(":rqes-data-classes")) | |||
There was a problem hiding this comment.
Doesn't seem to be really needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bad attempt at seperating RQES related files into two modules
rqes-data-classesandvck-rqeswith the latter being a placeholder for additional services which may or may not merge withvck-openiddepending on how pure we want to keep that module.This current version has the following short-comings:
rqes-data-classesis a dependency for everythingQesInputDescriptorshould be inrqes-data-classesbut is indif-data-classesfor serialization reasonsSignatureRequestParametersshould be inrqes-data-classesbut is inoauth-data-classesfor serialization reasonsBetter ideas/improvements very welcome