Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/client id scheme #150

Open
wants to merge 3 commits into
base: feature/refactor-issuing
Choose a base branch
from

Conversation

nodh
Copy link
Contributor

@nodh nodh commented Oct 21, 2024

Fixes #146 by refactoring the handling of client_id in SIOP

@nodh nodh self-assigned this Oct 21, 2024
@@ -296,7 +336,7 @@ class OidcSiopVerifier private constructor(
): KmmResult<JwsSigned> = catching {
val requestObject = createAuthnRequest(requestOptions)
val requestObjectSerialized = jsonSerializer.encodeToString(
requestObject.copy(audience = relyingPartyUrl, issuer = relyingPartyUrl)
requestObject.copy(audience = "https://self-issued.me/v2", issuer = "https://self-issued.me/v2")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use those strings as default values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants