CI: Run and report tests on push #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodh
force-pushed
the
feature/ci-test-on-push
branch
2 times, most recently
from
0f56d7e
to
3e99595
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Comment on lines
+33
to
+47
|
|
||
| val Base64UrlStrict = Base64(config = Base64ConfigBuilder().apply { | ||
| lineBreakInterval = 0 | ||
| encodeToUrlSafe = true | ||
| isLenient = true | ||
| padEncoded = false | ||
| }.build()) | ||
|
|
||
|
|
||
| val Base64Strict = Base64(config = Base64ConfigBuilder().apply { | ||
| lineBreakInterval = 0 | ||
| encodeToUrlSafe = false | ||
| isLenient = true | ||
| padEncoded = true | ||
| }.build()) |
There was a problem hiding this comment.
Why is it not used everywhere?
There was a problem hiding this comment.
Isn't this covered in #18 ?
There was a problem hiding this comment.
Sorry, that was very misleading and sloppy! Why don't we want such a shorthand also for Base16?
But come to think of it: Kotlin 1.9 ships with base64 and hex encoding. We might not need the library any more
This comment was marked as outdated.
This comment was marked as outdated.
|
I think this PR is ready to merge, please review |
nodh
force-pushed
the
feature/ci-test-on-push
branch
from
8b1139e
to
d1ebc94
Compare
JesusMcCloud
approved these changes
Sep 21, 2023
This implementas a rudimentary DER encoder for X.509 certificates
nodh
force-pushed
the
feature/ci-test-on-push
branch
from
d1ebc94
to
d2d4fd4
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.