-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SD-JWT representations #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! only change requests are in the review, the rest are comments/questions
vclib-aries/src/commonMain/kotlin/at/asitplus/wallet/lib/aries/IssueCredentialProtocol.kt
Show resolved
Hide resolved
vclib-aries/src/commonTest/kotlin/at/asitplus/wallet/lib/aries/DummyCredentialDataProvider.kt
Show resolved
Hide resolved
.also { Napier.w("verifySdJwt: Digest of disclosure not contained in SD-JWT: $it") } | ||
} | ||
} | ||
// TODO Revocation Check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general fine for me, but would this really be too much effort to add it before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implements representing verifiable credentials in SD-JWT format, in addition to the more common JWT. Builds upon the selective disclosure mechanisms in our library used for ISO mobile driving licences.