Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC Point Compression and Correct multibase encoding #37

Merged
merged 2 commits into from
Mar 14, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

Release NEXT:
- Update to latest KMP Crypto
- Introduces correct mulitbase encoding
- EC Point Compression
- **THIS IS A BREAKING CHANGE WRT. SOME ASPECTS OF SERIALIZATION**
nodh marked this conversation as resolved.
Show resolved Hide resolved
- Fix name shadowing of gradle plugins by renaming file `Plugin.kt` -> `VcLibConventions.kt`

Release 3.4.0:
- Target Java 17
- Updated dependencies from conventions: Bouncycastle 1.77, Serialization 1.6.3-snapshot (fork), Napier 2.7.1, KMP Crypto 2.3.0
Expand Down
10 changes: 0 additions & 10 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,6 @@ tasks.getByName("dokkaHtmlMultiModule") {
includes.from("README.md")
}

task<Exec>("purge") {
dependsOn("clean")
workingDir = layout.projectDirectory.dir("vclib").asFile
commandLine("./gradlew", "clean")
doFirst {
println("descending into ${workingDir.absolutePath}")
logger.lifecycle("Purging VcLib maven build")
}
}

val artifactVersion: String by extra
group = "at.asitplus.wallet"
version = artifactVersion
2 changes: 1 addition & 1 deletion kmp-crypto
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class JsonWebKeyJvmTest : FreeSpec({
jsonWebKey.keyId shouldHaveMinLength 32

"it can be recreated" {
val recreatedJwk = JsonWebKey.fromKeyId(jsonWebKey.keyId!!).getOrThrow()
val recreatedJwk = JsonWebKey.fromDid(jsonWebKey.keyId!!).getOrThrow()
recreatedJwk.keyId shouldBe jsonWebKey.keyId
recreatedJwk.x shouldBe jsonWebKey.x
recreatedJwk.y shouldBe jsonWebKey.y
Expand All @@ -54,7 +54,7 @@ class JsonWebKeyJvmTest : FreeSpec({
jsonWebKey.toCryptoPublicKey().getOrThrow().iosEncoded shouldBe ansiX962

"it can be recreated" {
val recreatedJwk = JsonWebKey.fromKeyId(jsonWebKey.keyId!!).getOrThrow()
val recreatedJwk = JsonWebKey.fromDid(jsonWebKey.keyId!!).getOrThrow()
recreatedJwk.keyId shouldBe jsonWebKey.keyId
recreatedJwk.x shouldBe jsonWebKey.x
recreatedJwk.y shouldBe jsonWebKey.y
Expand Down
Loading