Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Laravel 11, PHP8 and ZipStream 3.1 #139

Merged
merged 23 commits into from
May 15, 2024

Conversation

drjdr
Copy link
Contributor

@drjdr drjdr commented Dec 31, 2023

This will update for php8 and zipstream 3.1

  • Zipstream now uses php named arguments => require php 8
  • Spatie medialibrary 11 composer conflicts with zipstream 2 dependency

TODO:
Change MD5 hashes in 2 tests results.

@iambateman
Copy link

This will be very helpful! Likewise, I can't install sidecar until this is merged.

@drjdr
Copy link
Contributor Author

drjdr commented Jan 24, 2024

@iambateman
in your composer.json add the following as a temporary solution:

        "hammerstone/sidecar": "dev-main",
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/drjdr/sidecar.git"
        }
    ],

@iambateman
Copy link

oh nice that's perfect...thanks for your help on that!

@justsanjit
Copy link

Waiting for this to be merged and released.

@drjdr drjdr changed the title Update for PHP8 and ZipStream 3.1 Update for Laravel 11, PHP8 and ZipStream 3.1 Mar 19, 2024
@aarondfrancis
Copy link
Owner

I'll take a look at this tomorrow, thanks!

@duncanmcclean
Copy link

Looks like Laravel 11 compatibility has already been merged (see #141). It might be worth updating this PR to just update the PHP & Zipstream versions?

@roberttolton
Copy link

Any update on merging this?

@lionslair
Copy link

bump

@riabiy
Copy link

riabiy commented May 3, 2024

Can't believe this got stale, since it's such a bummer.

@riabiy
Copy link

riabiy commented May 15, 2024

@aarondfrancis
Thank you ❤️

One lil PR instead of 1000 words 🥹

@aarondfrancis
Copy link
Owner

Thank you all for your patience! ❤️ And thank you @drjdr for tackling this initially. I apologize for all the delays.

@aarondfrancis aarondfrancis merged commit 1fd2f35 into aarondfrancis:main May 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants