Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to create a dev environment #134

Closed
Mte90 opened this issue Jun 23, 2021 · 10 comments
Closed

How to create a dev environment #134

Mte90 opened this issue Jun 23, 2021 · 10 comments

Comments

@Mte90
Copy link
Contributor

Mte90 commented Jun 23, 2021

There is a way to develop in this project without requiring to record a video?

I am just looking to understand if there is a way to simplify the development on this projects without run docker, ffmpeg and so on.

@mtsonline
Copy link
Contributor

could you explain further, what you want to do?

@Mte90
Copy link
Contributor Author

Mte90 commented Jun 24, 2021

I want to fix the ticket I opened.
As I see now to do changes on this tool I need docker and to see if the code worked I need to record with ffmpeg.
This is not very helpful to test changes so I was looking if there was a more simple way to contribute it as developer on this.

@mtsonline
Copy link
Contributor

what ticket are you refering to?
I am not sure I fully understand what you want to do.
Without docker you would have to install a lot of tools manually, how should this help?
Without ffmpeg how would you stream?
What is your goal, exactly as possible?

@Mte90
Copy link
Contributor Author

Mte90 commented Jun 24, 2021

Sure :-)

#95
#127

As you can see they are ticket about the stuff showed on BBB and recorded with ffmpeg.
So to me they are just css tricks to enable but if I need docker to connect to an external instance and record a video it is kind of a long process to debug them.

Also if there is something simpler I can do also other improvements etc.

@mtsonline
Copy link
Contributor

ah, now I understand better what your problem is. :-)

good, a few thoughts on that:

  • for testing you do not need docker at all. You always can just use the get_join_url function and experiment there with new parameters. The url can be opened in any browser to see the results. You do not have to open through the streaming docker environment.

  • you will have to find a solution how to change something during a meeting via selenium. To test how / what to do with selenium you can do that outside the docker too. Just have a look at selenium and learn how to use this for your goals. I am not sure if it is possible or easy to do that during the session at all.

  • css styles won't be changeable during a meeting - this is something for opening a new meeting with some layout. To change during the meeting you need other solutions - see above.

hope this helps a bit ...?
cheers

@Mte90
Copy link
Contributor Author

Mte90 commented Jun 24, 2021

So to understand:

  • Get the url from
    return bbbUB.buildUrl("join", params=joinParams)
  • Try the url it in a browser
  • Try the url on Selenium
  • Trick selenium with python to do screenshots

So I think that I need a new python script to do all of that.

@mtsonline
Copy link
Contributor

why don't you want to use the dockericed setup? if you checkout the git repo and use the docker-compose example with build instead of the image one, you just can edit the lines locally in the python file.
after changing just restart the docker with build flag
docker-compose stop
docker-compose up --build -d
and the changes should be reflected.

I do not see a need for a separate dev environment

@Mte90
Copy link
Contributor Author

Mte90 commented Jun 24, 2021

I see that this stream.py file calls ffmpeg so I need to do some changes.
Anyway I don't use Docker and I prefer to have everything on the machine to speed up also.

I will keep you updated about my progress.

@mtsonline
Copy link
Contributor

without ffmpeg the whole tool would do nothing?!? What do you want to do without it? you would not get any file to store or stream to send via the network?

If you do not use docker you will never have the same versions of all components for each user and this may cause issues.

looking forward to your experiences and feedback
good luck

@Mte90
Copy link
Contributor Author

Mte90 commented Jun 24, 2021

Just in case for someone else that is looking to this.

On stream.py on the stream method you can add a code like this:


    global browser
    browser.save_screenshot("./screenshot.png")
    time.sleep(5)
    browser.save_screenshot("./screenshot2.png")

So you will get some screenshots

@Mte90 Mte90 closed this as completed Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants