Merge pull request #621 from pensono/nullable-struct

+semver:fix Fix nullable struct serialization
aaubry · Jun 28, 2021 · 665b182 · 665b182
2 parents 78a57da + 78ff21e
commit 665b182
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 2 deletions.
diff --git a/YamlDotNet.Test/Serialization/SerializationTestHelper.cs b/YamlDotNet.Test/Serialization/SerializationTestHelper.cs
@@ -141,6 +141,11 @@ public enum EnumExample
         Two
     }
 
+    public struct StructExample
+    {
+        public int Value { get; set; }
+    }
+
     public enum SByteEnum : sbyte { Default, Sbyte }
     public enum ByteEnum : byte { Default, Byte }
     public enum Int16Enum : short { Default, Short }

diff --git a/YamlDotNet.Test/Serialization/SerializationTests.cs b/YamlDotNet.Test/Serialization/SerializationTests.cs
@@ -183,6 +183,24 @@ public void RoundtripNullableEnums(EnumExample? value)
             result.Should().Be(value);
         }
 
+        [Fact]
+        public void RoundtripNullableStructWithValue()
+        {
+            var value = new StructExample { Value = 2 };
+
+            var result = DoRoundtripFromObjectTo<StructExample?>(value);
+
+            result.Should().Be(value);
+        }
+
+        [Fact]
+        public void RoundtripNullableStructWithoutValue()
+        {
+            var result = DoRoundtripFromObjectTo<StructExample?>(null);
+
+            result.Should().Be(null);
+        }
+
         [Fact]
         public void SerializeCircularReference()
         {

diff --git a/YamlDotNet/Serialization/NodeDeserializers/ObjectNodeDeserializer.cs b/YamlDotNet/Serialization/NodeDeserializers/ObjectNodeDeserializer.cs
@@ -47,11 +47,14 @@ bool INodeDeserializer.Deserialize(IParser parser, Type expectedType, Func<IPars
                 return false;
             }
 
-            value = objectFactory.Create(expectedType);
+            // Strip off the nullable type, if present. This is needed for nullable structs.
+            var implementationType = Nullable.GetUnderlyingType(expectedType) ?? expectedType;
+
+            value = objectFactory.Create(implementationType);
             while (!parser.TryConsume<MappingEnd>(out var _))
             {
                 var propertyName = parser.Consume<Scalar>();
-                var property = typeDescriptor.GetProperty(expectedType, null, propertyName.Value, ignoreUnmatched);
+                var property = typeDescriptor.GetProperty(implementationType, null, propertyName.Value, ignoreUnmatched);
                 if (property == null)
                 {
                     parser.SkipThisAndNestedEvents();