From ab6cb9c72a9b56ae6a536e7337b05692f0e22a88 Mon Sep 17 00:00:00 2001
From: Thayer <thayeralshaabi@gmail.com>
Date: Tue, 17 Oct 2023 16:17:22 -0400
Subject: [PATCH] add CDFs

---
 src/eval.py | 45 ++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 42 insertions(+), 3 deletions(-)

diff --git a/src/eval.py b/src/eval.py
index 538846d7..524da8cd 100644
--- a/src/eval.py
+++ b/src/eval.py
@@ -584,6 +584,19 @@ def plot_heatmap_p2v(
                 bins=25,
                 color='dimgrey'
             )
+
+            ax1t = ax1.twinx()
+            ax1t = sns.ecdfplot(
+                ax=ax1t,
+                data=x,
+                x=hist_col,
+                stat='proportion',
+                color='C2',
+                linestyle=':',
+            )
+            ax1t.tick_params(axis='y', labelcolor='C2', color='C2')
+            ax1t.set_ylabel('CDF', color='C2')
+
             ax1.axvline(np.median(x[hist_col]), c='C0', ls='-', lw=2, label='Median')
             ax1.axvline(np.mean(x[hist_col]), c='C1', ls='--', lw=2, label='Mean')
             ax1.set_ylim(0, 30)
@@ -624,6 +637,18 @@ def plot_heatmap_p2v(
                 bins=25,
                 color='dimgrey'
             )
+            ax2t = ax2.twinx()
+            ax2t = sns.ecdfplot(
+                ax=ax2t,
+                data=x,
+                x=hist_col,
+                stat='proportion',
+                color='C2',
+                linestyle=':',
+            )
+            ax2t.tick_params(axis='y', labelcolor='C2', color='C2')
+            ax2t.set_ylabel('CDF', color='C2')
+
             ax2.axvline(np.median(x[hist_col]), c='C0', ls='-', lw=2)
             ax2.axvline(np.mean(x[hist_col]), c='C1', ls='--', lw=2)
             ax2.set_ylim(0, 30)
@@ -664,6 +689,19 @@ def plot_heatmap_p2v(
                 bins=25,
                 color='dimgrey'
             )
+
+            ax3t = ax3.twinx()
+            ax3t = sns.ecdfplot(
+                ax=ax3t,
+                data=x,
+                x=hist_col,
+                stat='proportion',
+                color='C2',
+                linestyle=':',
+            )
+            ax3t.tick_params(axis='y', labelcolor='C2', color='C2')
+            ax3t.set_ylabel('CDF', color='C2')
+
             ax3.axvline(np.median(x[hist_col]), c='C0', ls='-', lw=2)
             ax3.axvline(np.mean(x[hist_col]), c='C1', ls='--', lw=2)
             ax3.set_ylim(0, 30)
@@ -694,11 +732,11 @@ def plot_heatmap_p2v(
 
             ax1.legend(frameon=False, ncol=1, loc='upper left')
             ax1.yaxis.set_major_formatter(PercentFormatter(decimals=0))
-            ax1.grid(True, which="both", axis='both', lw=.25, ls='--', zorder=0)
+            ax1t.grid(True, which="both", axis='both', lw=.25, ls='--', zorder=0)
             ax2.yaxis.set_major_formatter(PercentFormatter(decimals=0))
-            ax2.grid(True, which="both", axis='both', lw=.25, ls='--', zorder=0)
+            ax2t.grid(True, which="both", axis='both', lw=.25, ls='--', zorder=0)
             ax3.yaxis.set_major_formatter(PercentFormatter(decimals=0))
-            ax3.grid(True, which="both", axis='both', lw=.25, ls='--', zorder=0)
+            ax3t.grid(True, which="both", axis='both', lw=.25, ls='--', zorder=0)
 
         elif label == f'Number of iterations':
 
@@ -716,6 +754,7 @@ def plot_heatmap_p2v(
                 color='dimgrey'
             )
 
+
             ax1.axvline(np.median(x[hist_col]), c='C0', ls='-', lw=2)
             ax1.axvline(np.mean(x[hist_col]), c='C1', ls='--', lw=2)
             ax1.axvline(np.median(x[hist_col]), c='C0', ls='-', lw=2, label='Median')