Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric overrides collide with ActiveSupport #18

Open
aviemet opened this issue Mar 1, 2024 · 2 comments
Open

Numeric overrides collide with ActiveSupport #18

aviemet opened this issue Mar 1, 2024 · 2 comments
Assignees

Comments

@aviemet
Copy link

aviemet commented Mar 1, 2024

Hi, not sure if you're still maintaining this package. I wanted to try using this in a Rails project, but ended up with some errors in other packages because of the time method overrides. The return values from seconds, minutes, etc. are different than those from the same methods in ActiveSupport.

Is there a way to disable the class extension by any chance since all of those methods are already provided by Rails?

Thank you

@aberant
Copy link
Owner

aberant commented Mar 14, 2024

Huh, I don't see any uses of these methods. I'm going to look into removing lib/osc-ruby/core_ext/numeric.rb

@aberant aberant self-assigned this Mar 14, 2024
@aberant
Copy link
Owner

aberant commented Jul 21, 2024

This should be fixed in 1.1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants