Fix typing, move exceptions to single file

abersheeran · Jul 31, 2024 · b8c3ff6 · b8c3ff6
1 parent 5eaed8c
commit b8c3ff6
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 13 deletions.
diff --git a/ratelimit/core.py b/ratelimit/core.py
@@ -24,7 +24,7 @@ async def default_429(scope: Scope, receive: Receive, send: Send) -> None:
     return default_429
 
 
-def _on_backend_error(err) -> ASGIApp:
+def _on_backend_error(err: Exception) -> ASGIApp:
     async def default_503(scope: Scope, receive: Receive, send: Send) -> None:
         await send(
             {
@@ -51,7 +51,7 @@ def __init__(
         *,
         on_auth_error: Optional[Callable[[Exception], Awaitable[ASGIApp]]] = None,
         on_blocked: Callable[[int], ASGIApp] = _on_blocked,
-        on_backend_error: Callable[[int], ASGIApp] = _on_backend_error,
+        on_backend_error: Callable[[Exception], ASGIApp] = _on_backend_error,
     ) -> None:
         self.app = app
         self.authenticate = authenticate

diff --git a/ratelimit/exceptions/backend_connection.py → ratelimit/exceptions.py b/ratelimit/exceptions/backend_connection.py → ratelimit/exceptions.py
@@ -1,4 +1,9 @@
-from .base_backend import BaseBackendException
+class BaseBackendException(Exception):
+    """
+    Base class for exception raised by Backends
+    """
+
+    pass
 
 
 class BackendConnectionException(BaseBackendException):

diff --git a/ratelimit/exceptions/__init__.py b/ratelimit/exceptions/__init__.py
diff --git a/ratelimit/exceptions/base_backend.py b/ratelimit/exceptions/base_backend.py
diff --git a/tests/test_core.py b/tests/test_core.py
@@ -179,7 +179,7 @@ async def test_custom_on_backend_error():
         assert response.text == "custom 503 page"
 
 
-def yourself_503(retry_after: int):
+def yourself_503(err: Exception):
     async def inside_yourself_503(scope: Scope, receive: Receive, send: Send) -> None:
         await send({"type": "http.response.start", "status": 503})
         await send(