-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'dot' line mode #2
base: master
Are you sure you want to change the base?
Conversation
This commit adds a new 'dot' line mode which produces small dots via very short lines. This is useful for plotting dithered art.
Thanks for your contribution! This is an interesting mode, however I don't understand the rationale behind using the Also:
|
Hah, there's no reason behind my using the I've removed |
) | ||
|
||
paths = [vp.circle(i, j, pen_width * 0.05) | ||
for i, j in zip(indice_j, indice_i)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should read as follows, for correctness and clarity:
paths = [vp.circle(j * pen_width, i * pen_width, pen_width * 0.05)
for j, i in zip(indice_j, indice_i)]
In particular, the * pen_width
is needed such that the grid is indeed scaled by the pen width.
FYI, I made some changes that will probably need you to rebase and force-push. |
This commit adds a new 'dot' line mode which produces small dots via very short lines. This is useful for plotting dithered art.