Small refactor

abhabongse · Mar 30, 2024 · 461062a · 461062a
1 parent 89fdd0d
commit 461062a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 14 deletions.
diff --git a/.github/workflows/python-check.yml b/.github/workflows/python-check.yml
@@ -9,7 +9,13 @@ on:
     branches: [ main ]
 
 jobs:
-  poetry-check:
+  ruff:
+    name: Ruff code linting and formatting
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: chartboost/ruff-action@v1
+  poetry:
     name: Poetry check
     runs-on: ubuntu-latest
     steps:
@@ -39,12 +45,6 @@ jobs:
       - name: Run poetry check
         run: |
           poetry check
-  ruff:
-    name: Ruff code linting and formatting
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: chartboost/ruff-action@v1
   pytest:
     name: Pytest unit testing
     strategy:

diff --git a/pyproject.toml b/pyproject.toml
@@ -24,14 +24,12 @@ quote-style = "preserve"
 skip-magic-trailing-comma = true
 
 [tool.ruff.lint]
-ignore = ["COM812", "ISC001"]
+ignore = ["COM812", "ISC001"]  # conflicting with ruff formatter
 select = [
-    "F", "E", "W", "C90", "I", "UP", "ASYNC",
-    "S", "BLE", "FBT003", "B", "A", "COM", "C4", "FA",
-    "ISC", "ICN", "G", "PT", "RSE", "RET", "SLOT",
-    "SIM101", "SIM105", "SIM107", "SIM110", "SIM113",
-    "SIM115", "SIM117", "SIM118", "SIM2", "SIM3",
-    "SIM4", "SIM9", "TID", "TCH", "PTH", "PD", "PGH",
+    "F", "E", "W", "C90", "I", "UP", "ASYNC", "S", "BLE", "FBT003", "B", "A",
+    "COM", "C4", "FA", "ISC", "ICN", "G", "PT", "RSE", "RET", "SLOT",
+    "SIM101", "SIM105", "SIM107", "SIM110", "SIM113", "SIM115", "SIM117",
+    "SIM118", "SIM2", "SIM3", "SIM4", "SIM9", "TID", "TCH", "PTH", "PD", "PGH",
     "PL", "FLY", "PERF", "RUF",
 ]