Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle Size #631

Open
aress31 opened this issue Sep 13, 2021 · 2 comments · May be fixed by #823
Open

Bundle Size #631

aress31 opened this issue Sep 13, 2021 · 2 comments · May be fixed by #823

Comments

@aress31
Copy link

aress31 commented Sep 13, 2021

Whilst this project is amazing and should be included out of the box as a Yup rule, I can't help but notice the huge bundle size, see:

image

Could you please consider refactoring and improving the code so that it gets reflected in the bundle size? 🙏
@JamesSingleton
Copy link

@aress31 I am right there with you... I just noticed this adds about 103 KB to my Next.js page which ended up being a little over half the page size.

@t-heuser
Copy link

Just leaving https://gitlab.com/catamphetamine/libphonenumber-js here. We're using this for formatting phone numbers but it can also validate them. Replacing google-libphonenumber with this package would lower the bundle size without much effort invested.

@sanduluca sanduluca linked a pull request May 10, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reduced bundle size (used libphonenumber-js) sanduluca/yup-phone
3 participants
@aress31 @JamesSingleton @t-heuser