Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High Throughput Algae Cell Detection #421 #453

Merged
merged 13 commits into from
Jan 23, 2024

Conversation

ARPIT2128
Copy link
Contributor

Pull Request for DL-Simplified 💡

Issue Title : #417

  • Info about the related issue (Aim of the project) : The aim of this project is to detect high throughput Algae cell using Deep Learning and OpenCV methods.
  • Name: ARPIT SHARMA
  • GitHub ID: My Github
  • Email ID: arpitsharma2128@gmail.com
  • denitfy yourself: SWOC 2024 Participant

Closes: #issue number that will be closed through this PR

Describe the add-ons or changes you've made 📃

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Implemented on synced fork from here so less chance to cause issues for main branch of this repo.

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @ARPIT2128 :)

@ARPIT2128
Copy link
Contributor Author

Updated the PR as per request @abhisheks008

@abhisheks008
Copy link
Owner

Follow the README template and update it. I liked the emojified version but it is missing out some important documentation points.

README template, https://github.com/abhisheks008/DL-Simplified/blob/main/.github/readme_template.md

Project to watch out for documentation, https://github.com/abhisheks008/ML-Crate/tree/main/Nurse%20Stress%20Prediction

@ARPIT2128

@abhisheks008 abhisheks008 added the Status: Requested Changes Changes requested. label Jan 21, 2024
@abhisheks008 abhisheks008 linked an issue Jan 21, 2024 that may be closed by this pull request
@ARPIT2128
Copy link
Contributor Author

@abhisheks008 sure, i will look into it

@ARPIT2128
Copy link
Contributor Author

Updated according to requested review @abhisheks008

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super satisfied.

Approved @ARPIT2128

@abhisheks008 abhisheks008 added Status: Approved Approved PR by the PA. Level: HARD SWOC S4 Issues under Social Winter of Code, 2025 and removed Status: Requested Changes Changes requested. labels Jan 23, 2024
@abhisheks008 abhisheks008 merged commit e98aa4c into abhisheks008:main Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: HARD Points Updated Status: Approved Approved PR by the PA. SWOC S4 Issues under Social Winter of Code, 2025
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High Throughput Algae Cell Detection
2 participants