Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README Enhancement - Avocados Classification #480

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

mariam7084
Copy link
Contributor

Pull Request for DL-Simplified 💡

Issue Title : README Enhancement - Avocados Classification

  • Info about the related issue (Aim of the project) : readme modification according to template
  • Name: Mariam
  • GitHub ID: github.com/mariam7084
  • Email ID: mariammanaullah1503@gmail.com
  • **Idenitfy yourself: ** DWoC 2023

Closes: #472

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

checked the preview of the modified readme to ensure better and appealing look

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @mariam7084 :)

@abhisheks008
Copy link
Owner

Hi @mariam7084 can you add some EDA results from the project and put them in the README file. Also try out the new README template, use emojis to make it attractive, https://github.com/abhisheks008/DL-Simplified/blob/main/.github/readme_template.md

@abhisheks008 abhisheks008 added Status: Requested Changes Changes requested. DWOC Issues under DWOC24 labels Jan 30, 2024
emojis added
added images
@mariam7084
Copy link
Contributor Author

@abhisheks008
added emojis and images of evaluation metrics of the models implemented as no images as a result of EDA were found.

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Please fix the orientation.

@mariam7084
Copy link
Contributor Author

@abhisheks008
orientation fixed.

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved @mariam7084 under DWOC.

@abhisheks008 abhisheks008 added Status: Approved Approved PR by the PA. level 2 Level 2 for GSSOC documentation Improvements or additions to documentation and removed Status: Requested Changes Changes requested. labels Feb 1, 2024
@abhisheks008 abhisheks008 merged commit ef4a9f4 into abhisheks008:main Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation DWOC Issues under DWOC24 level 2 Level 2 for GSSOC Status: Approved Approved PR by the PA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README Enhancement - Avocados Classification
2 participants