Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facial Emotion Detection #481

Merged
merged 16 commits into from
Feb 1, 2024
Merged

Facial Emotion Detection #481

merged 16 commits into from
Feb 1, 2024

Conversation

siddhant4ds
Copy link
Contributor

Pull Request for DL-Simplified 💡

Issue Title : Facial Emotion Detection

  • Info about the related issue (Aim of the project) : Training a deep learning model to classify 4 facial emotions from 48x48 grayscale images.
  • Name: Siddhant Tiwari
  • GitHub ID: https://github.com/siddhant4ds
  • Email ID: siddhant.tiwari.ds@gmail.com
  • Idenitfy yourself: (Mention in which program you are contributing in. Eg. For a JWOC 2022 participant it's, JWOC Participant) SWOC-S4 (2024)

Closes: #232

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Changes made and tested on Jupyter (Google Colab and Kaggle) notebooks. [Requires GPU]

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

@github-actions GitHub Actions
Copy link

Our team will soon review your PR. Thanks @siddhant4ds :)

abhisheks008
abhisheks008 requested changes Feb 1, 2024
View reviewed changes
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project folder name should be same as the issue name with no hyphen and underscore.

@abhisheks008 abhisheks008 added the Status: Requested Changes Changes requested. label Feb 1, 2024
@siddhant4ds siddhant4ds changed the title Added "Facial-Emotion-Detection" project Added "Facial Emotion Detection" project Feb 1, 2024
@siddhant4ds
Copy link
Contributor Author

@abhisheks008 I have made the requested change. Please let me know if any other changes are needed.

abhisheks008
abhisheks008 requested changes Feb 1, 2024
View reviewed changes
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your overall project is looking good to me. Need some minor changes in the README file.

Facial Emotion Detection/Model/README.md Outdated
**DATASET:** [FER-DS - Kaggle](https://www.kaggle.com/datasets/mhantor/facial-expression)

**DESCRIPTION:**
We have 19950 images covering 4 facial emotions (angry, happy, neutral, surprised).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use bullet points/numbering.

Facial Emotion Detection/Model/README.md Outdated
| EfficientNetV2S + Simple data-augment | **84.24** | **82.86** |

**CONCLUSION:**
We used low-resolution, grayscale images to train a deep learning model to detect four facial emotions.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use bullet points/numbering.

@siddhant4ds
Copy link
Contributor Author

@abhisheks008 I have updated the formatting in the project summary. Please let me know if any other changes are needed.

abhisheks008
abhisheks008 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved @siddhant4ds under SWOC S4.

@abhisheks008 abhisheks008 added Status: Approved Approved PR by the PA. Level: HARD SWOC S4 Issues under Social Winter of Code, 2025 and removed Status: Requested Changes Changes requested. labels Feb 1, 2024
@abhisheks008 abhisheks008 merged commit 5632358 into abhisheks008:main Feb 1, 2024
@abhisheks008 abhisheks008 changed the title Added "Facial Emotion Detection" project Facial Emotion Detection Feb 1, 2024
@siddhant4ds siddhant4ds deleted the facial-emotion-detection branch February 1, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhisheks008 abhisheks008 abhisheks008 approved these changes

Assignees

@siddhant4ds siddhant4ds

Labels
Level: HARD Points Updated Status: Approved Approved PR by the PA. SWOC S4 Issues under Social Winter of Code, 2025
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Facial Emotion Detection
2 participants
@siddhant4ds @abhisheks008