Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spam Vs Ham Mail Classification [With Streamlit GUI] #490

Closed
wants to merge 5 commits into from

Conversation

dipayan22
Copy link
Contributor

Pull Request for DL-Simplified 💡

Issue Title : Spam Vs Ham Mail Classification [With Streamlit GUI] #329

  • Info about the related issue (Aim of the project) : ML project with a Streamlit GUI that will predict whether the Mail received from some source is a Spam Mail or not
  • Name: Dipayan Majumder
  • GitHub ID: dipayan22
  • Email ID: majumderd007@gmail.com
  • Idenitfy yourself: (Mention in which program you are contributing in. Eg. For a JWOC 2022 participant it's, JWOC Participant) SWOC 24

Closes: #issue number that will be closed through this PR

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @dipayan22 :)

@abhisheks008
Copy link
Owner

abhisheks008 commented Feb 11, 2024

Hi @dipayan22 the project is working fine. Need to upgrade the README file by adding the EDA results under the Visualization tag, use <heading> tags for the topics, create a table consisting all the accuracy scores of the models, find a brief conclusion of the project. Also have you used Streamlit for creating a GUI for this project?

@dipayan22
Copy link
Contributor Author

Yes i have used Streamlit GUI . In every notebook file at the last i made a Streamlit GUI for this project.

@dipayan22
Copy link
Contributor Author

Do I have to make a separate .py file for making the Streamlit GUI in the Model folder?

@abhisheks008
Copy link
Owner

Do I have to make a separate .py file for making the Streamlit GUI in the Model folder?

That will be better.

@dipayan22
Copy link
Contributor Author

File updated .

@abhisheks008
Copy link
Owner

image

I think you missed to add the EDA results (images) under the EDA tag.
Accuracy scores of the models will be showcased after the EDA results.
@dipayan22

@abhisheks008 abhisheks008 linked an issue Feb 13, 2024 that may be closed by this pull request
@dipayan22
Copy link
Contributor Author

@abhisheks008 You can check now . REABME.md file is updated.

@abhisheks008
Copy link
Owner

I couldn't find the Streamlit file in the model folder with .py extension.
Can you update that?

@dipayan22 dipayan22 closed this Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Requested Changes Changes requested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spam Vs Ham Mail Classification [With Streamlit GUI]
2 participants