Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urban Sound Analysis - Sound Classification #978

Merged
merged 21 commits into from
Nov 10, 2024

Conversation

SimranShaikh20
Copy link
Contributor

@SimranShaikh20 SimranShaikh20 commented Nov 7, 2024

Pull Request for DL-Simplified 💡

Issue no -#963

Issue Title :

Describe the add-ons or changes you've made 📃

I have added folder with all mandatory files to main branch
Give a clear description of what have you added or modifications made

Type of change ☑️

Add project for urban sound analysis and classification

Example how to mark a checkbox:-

  • My code follows the code style of this project.
    -->
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

github-actions bot commented Nov 7, 2024

Our team will soon review your PR. Thanks @SimranShaikh20 :)

@SimranShaikh20
Copy link
Contributor Author

@abhisheks008 kindly review my PR and merged !
if there is any conflicts let me know about it .

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-arrange the files according to the project structure,

Project Folder
|- Dataset
   |- dataset.csv (dataset used for the particula project)
   |- README.md (brief about the dataset)
|- Images
   |- img1.png
   |- img2.png
   |- img3.png
|- Model
   |- project_folder.ipynb
   |- README.md
|- Web App
   |- templates
   |- img3.png
|- Model
   |- project_folder.ipynb
   |- README.md
|- requirements.txt

Project folder name should be, Urban Sound Classification using Deep Learning

@SimranShaikh20

@SimranShaikh20
Copy link
Contributor Author

@abhisheks008 added entire project based on above formet !
kindly review it and merged !

@SimranShaikh20
Copy link
Contributor Author

Please re-arrange the files according to the project structure,

Project Folder
|- Dataset
   |- dataset.csv (dataset used for the particula project)
   |- README.md (brief about the dataset)
|- Images
   |- img1.png
   |- img2.png
   |- img3.png
|- Model
   |- project_folder.ipynb
   |- README.md
|- Web App
   |- templates
   |- img3.png
|- Model
   |- project_folder.ipynb
   |- README.md
|- requirements.txt

Project folder name should be, Urban Sound Classification using Deep Learning

Suggestion for above format you must include this format in repo so that new contributor able to know how to add file with particular format

this will save your time as well as contributor time becoz once we upload file then again we have to change entire format this take more time !

@abhisheks008 if you permits i will create new for this
Issue description - Format to contribute in project

@SimranShaikh20
Copy link
Contributor Author

SimranShaikh20 commented Nov 10, 2024

@abhisheks008 for that you have to provide me format for all type contirbution !

@SimranShaikh20
Copy link
Contributor Author

@abhisheks008 !

@abhisheks008
Copy link
Owner

Cool then create a new issue and put the project structure in the project repository's README.

For this pull request give me some time, I'll review it ASAP.

@SimranShaikh20

@abhisheks008
Copy link
Owner

@abhisheks008 for that you have to provide me format for all type contirbution !

For every contribution here in this project repository contributors have to follow the same project structure as the issues are mainly project based.

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Models are correctly implemented hence upgrading the level of the issue and pull request.

@SimranShaikh20

@abhisheks008 abhisheks008 added Status: Approved Approved PR by the PA. level 3 Level 3 for GSSOC and removed Status: Requested Changes Changes requested. labels Nov 10, 2024
@abhisheks008 abhisheks008 merged commit a2a2c63 into abhisheks008:main Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext level 3 Level 3 for GSSOC Points Updated Status: Approved Approved PR by the PA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE REQUESTED : Urban Sound Analysis - Sound Classification
2 participants