Align tool.setuptools.dynamic.optional-dependencies with `project.o…

…ptional-dependencies` (#170)
abravalheri · May 7, 2024 · dfcb47c · dfcb47c
2 parents 2d5e8d3 + b1d99d8
commit dfcb47c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/src/validate_pyproject/plugins/setuptools.schema.json b/src/validate_pyproject/plugins/setuptools.schema.json
@@ -219,7 +219,7 @@
         "dependencies": {"$ref": "#/definitions/file-directive-for-dependencies"},
         "optional-dependencies": {
           "type": "object",
-          "propertyNames": {"type": "string", "format": "python-identifier"},
+          "propertyNames": {"type": "string", "format": "pep508-identifier"},
           "additionalProperties": false,
           "patternProperties": {
             ".+": {"$ref": "#/definitions/file-directive-for-dependencies"}

diff --git a/tests/examples/setuptools/10-pyproject.toml b/tests/examples/setuptools/10-pyproject.toml
@@ -0,0 +1,7 @@
+[project]
+name = "myproj"
+version = "42"
+dynamic = ["optional-dependencies"]
+
+[tool.setuptools.dynamic.optional-dependencies]
+name-with-hyfens = {file = "extra.txt"}
diff --git a/tests/invalid-examples/setuptools/dependencies/invalid-extra-name.errors.txt b/tests/invalid-examples/setuptools/dependencies/invalid-extra-name.errors.txt
@@ -1,3 +1,3 @@
 `tool.setuptools.dynamic.optional-dependencies` keys must be named by:
 
-    {type: string, format: 'python-identifier'}
+    {type: string, format: 'pep508-identifier'}