fix(bump): also propagate the parserOpts from args to conventionalRecommendedBump #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, to resolve the following behaviour (raised in the deprecated origin: conventional-changelog#690 (comment)) I've taken the idea and change of an already opened pull request conventional-changelog#821 (also from the deprecated origin) to fix it.
The bug thats observed is that when using the
parserOpts
and settingheaderPattern
to for example match the Azure DevOps prefix e.g using this regex"(?:\\(Merged PR \\d+: \\))?([a-zA-Z]+)(?:\\(([\\w$\\.\\-*\\s]*)\\))?\\!?:(.*)"
features committed with e.g. "feat: abc" and then merged as "Merged PR 0: feat: abc" are classified correctly when writing them to the changelog but the bump only increases the patch. Thats the default bump. The bump uses the default config and the parserOpts seem not to be propagated.parserOpts
(andwriterOpts
) were added but only for the changelog lifecycle, as far as I can see: #37Any concerns about this fix? :)