From 8a8eb303d1013676bf669116ddc8f056e8a445d8 Mon Sep 17 00:00:00 2001
From: Roger Abelenda <roger.abelenda@abstracta.com.uy>
Date: Wed, 13 Mar 2024 11:01:00 -0300
Subject: [PATCH] Use latest selenium version in recorder to avoid issues with
 latest chrome versions

This change requires changing the required jvm for recorder & jmx2dsl
---
 .github/workflows/build.yml      | 2 +-
 .github/workflows/release.yml    | 2 +-
 docs/guide/jmx2dsl.md            | 6 ++++++
 docs/guide/recorder/index.md     | 6 ++++++
 jmeter-java-dsl-cli/pom.xml      | 3 +++
 jmeter-java-dsl-recorder/pom.xml | 6 ++++++
 pom.xml                          | 4 ++--
 7 files changed, 25 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index e8234409..ec649892 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -14,7 +14,7 @@ jobs:
       - uses: actions/setup-java@v3
         with:
           distribution: temurin
-          java-version: 8
+          java-version: 11
           cache: maven
       - uses: browser-actions/setup-chrome@v1
       - name: Run maven tests
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index a0463291..75dab2a2 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -15,7 +15,7 @@ jobs:
       - uses: actions/setup-java@v3
         with:
           distribution: temurin
-          java-version: 8
+          java-version: 11
           cache: maven
       - uses: actions/setup-node@v3
         with:
diff --git a/docs/guide/jmx2dsl.md b/docs/guide/jmx2dsl.md
index 46cfa4bd..abacfd08 100644
--- a/docs/guide/jmx2dsl.md
+++ b/docs/guide/jmx2dsl.md
@@ -76,6 +76,12 @@ public class PerformanceTest {
 }
 ```
 
+::: warning
+Unlike the rest of JMeter DSL which is compiled with Java 8, `jmdsl.jar` and `us.abstracta.jmeter:jmeter-java-dsl-cli` are compiled with Java 11 due to some dependencies requirement (latest Selenium drivers mainly).
+
+So, to run above commands, you will need Java 11 or newer.
+:::
+
 ::: tip
 Review and try generated code before executing it as is. I.e: tune thread groups and iterations to 1 to give it a try.
 :::
diff --git a/docs/guide/recorder/index.md b/docs/guide/recorder/index.md
index 1dff7746..a0c409c6 100644
--- a/docs/guide/recorder/index.md
+++ b/docs/guide/recorder/index.md
@@ -22,6 +22,12 @@ Use `java -jar jmdsl.jar help recorder` to see the list of options to customize
 In general use `---url-includes` to ignore URLs that are not relevant to the performance test.
 :::
 
+::: warning
+Unlike the rest of JMeter DSL, which is compiled with Java 8, `jmdsl.jar` and `us.abstracta.jmeter:jmeter-java-dsl-cli` are compiled with Java 11 due to some dependencies requirement (latest Selenium drivers mainly).
+
+So, to run above commands, you will need Java 11 or newer.
+:::
+
 ### Correlations
 
 To avoid fragile test plans with fixed values in request parameters, the DSL recorder, through the usage of the [JMeter Correlation Recorder Plugin](https://github.com/Blazemeter/CorrelationRecorder), allows you to define correlation rules.
diff --git a/jmeter-java-dsl-cli/pom.xml b/jmeter-java-dsl-cli/pom.xml
index 2e16684a..bc424cbd 100644
--- a/jmeter-java-dsl-cli/pom.xml
+++ b/jmeter-java-dsl-cli/pom.xml
@@ -17,6 +17,9 @@
   <properties>
     <picocli.version>4.7.1</picocli.version>
     <log4j.version>2.19.0</log4j.version>
+    <!-- Using java 11 since last version of selenium driver with java 8 does not have support for latest version of chrome driver. -->
+    <maven.compiler.source>11</maven.compiler.source>
+    <maven.compiler.target>11</maven.compiler.target>
   </properties>
 
   <dependencies>
diff --git a/jmeter-java-dsl-recorder/pom.xml b/jmeter-java-dsl-recorder/pom.xml
index a89ed5da..eb3675d3 100644
--- a/jmeter-java-dsl-recorder/pom.xml
+++ b/jmeter-java-dsl-recorder/pom.xml
@@ -16,6 +16,12 @@
     projects (ej: jmeter-java-dsl-cli)
   </description>
 
+  <properties>
+    <!-- Using java 11 since last version of selenium driver with java 8 does not have support for latest version of chrome driver. -->
+    <maven.compiler.source>11</maven.compiler.source>
+    <maven.compiler.target>11</maven.compiler.target>
+  </properties>
+
   <dependencies>
     <dependency>
       <groupId>com.blazemeter</groupId>
diff --git a/pom.xml b/pom.xml
index dd97b530..f333d9da 100644
--- a/pom.xml
+++ b/pom.xml
@@ -55,8 +55,7 @@
     <junit-platform.version>1.9.1</junit-platform.version>
     <assertj-core.version>3.23.1</assertj-core.version>
     <jackson.version>2.14.2</jackson.version>
-    <!-- This is the last version compatible with java 8. 4.14 requires java 11. -->
-    <selenium.version>4.13.0</selenium.version>
+    <selenium.version>4.18.0</selenium.version>
     <!-- same version as JMeter dependency -->
     <slf4j.version>1.7.36</slf4j.version>
     <retrofit.version>2.9.0</retrofit.version>
@@ -174,6 +173,7 @@
           <version>3.11.0</version>
           <configuration>
             <compilerArgs>
+              <!-- this is to preserve parameters names, mainly for bridge service reflection logic -->
               <arg>-parameters</arg>
             </compilerArgs>
           </configuration>