Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Candidate v1.1.0 #59

Merged
merged 255 commits into from
Mar 5, 2021
Merged

Release Candidate v1.1.0 #59

merged 255 commits into from
Mar 5, 2021

Conversation

aburrell
Copy link
Owner

@aburrell aburrell commented Feb 23, 2021

Release candidate for version 1.1.0.

Summary of Changes

  • Adapted Fortran to read IRGF coefficients from a file (updated to IGRF-13)
  • Improved the subsol routine to allow array input
  • Improved PEP8 compliance
  • Added some missing docstrings to unit tests
  • Fixed AppVeyor test environment
  • Updated python test versions
  • Updated community and package documentation
  • Fixed bug where NaNs caused array input to crash
  • Fixed bug in quasi-dipole to apex conversion at equator
  • Removed duplicate CI services

Release Checklist

aburrell and others added 30 commits July 6, 2018 16:41
Removed support for 3.3 and added support for 3.7.
Improved wheel logic so that no user specified environment variables are required.
Added comments containing two of the individual flags needed in comments and the general static flag as the real flag.
Improved error message
Changed static flag option since f2py doesn't use the makefile
This is giving travis coniption fits.
3.7 isn't ready for testing yet.
Better error message for compilation problems.
[Feature] Ability to generate the magnetic field vector in apex coordinates.
IGRF coefficients are directly read from ASCII-file instead of using
hard-coded values. This omits adding the coefficients manually in
the future.
IGRF.f90 needs to be compiled first to make module available in
linking.
Added some missing docstrings an simplified some tests.
Made a handful of PEP8 improvemeents and added a missing docstring.
Fixed unit tests that were failing on Travis due to a change in warning behaviour.  Also added some missing docstrings and added more constraints to the unit tests under scrutiny.
Reverted style include whitespace around code pertaining to a block comment and ajusted line length.
Future-proofed the new doctrings.
Updated the changelog with a summary of updates in this pull request.
adding support for numpy.ndarray and numpy.datetime64 to helpers.subsol
modifying appveyor.yml, removing 3.4 and fix-compiler-error.py
asreimer and others added 11 commits February 25, 2021 23:24
Improve robustness of unit tests for command line calls by ensuring access to apexpy on systems without the executable in the path.
Remove the extra whitespace before a comma.
Added a relative tolerance limit to `test_apxg2all` unit test.
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
[BUG]: Update apexshdat with IGRF13
Copy link
Collaborator

@asreimer asreimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some polish-related comments and questions for the documentation. Otherwise it's looking good to me!

README.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
Fixed wording and spellings.

Co-authored-by: Ashton Reimer <ashtonsethreimer@gmail.com>
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
src/fortranapex/readme.txt Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
@aburrell aburrell requested a review from asreimer March 4, 2021 16:02
asreimer and others added 4 commits March 4, 2021 17:40
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
@asreimer
Copy link
Collaborator

asreimer commented Mar 5, 2021

The only thing left to do now might be to test this:

pip install --global-option='build_ext' apexpy

on macOS to see if it works without the --no-use-pep517. Based on experience with Windows and Linux, without --no-use-pep517, it tries to build all of the dependencies listed in the pyproject.toml because:

Disabling all use of wheels due to the use of --build-option / --global-option / --install-option.

So it disables wheels even for the dependencies. If we want users to only rebuild the apexpy package, this seems to do that:

pip install --no-binary :apexpy: apexpy

Changing the docs to use the above command might be the way to go so we aren't implicitly asking users to compile Cython and numpy.

Copy link
Collaborator

@asreimer asreimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After verifying the suspected issues with recommending:

pip install --global-option build_ext apexpy

to users, I updated the documentation to recommend:

pip install --no-binary :apexpy: apexpy

instead. I think this covers all the issues we had that are relevant to this release.

@aburrell aburrell merged commit ba9c592 into main Mar 5, 2021
@aburrell aburrell deleted the rc_v1.1.0 branch March 5, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STY: change base branch to main
6 participants