-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: various validation related issues (resolves #1776, #1775, #1774, #1773, #1772) #1820
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1820 +/- ##
============================================
+ Coverage 96.47% 96.52% +0.04%
- Complexity 1984 2032 +48
============================================
Files 299 301 +2
Lines 8636 8746 +110
============================================
+ Hits 8332 8442 +110
Misses 304 304
|
Also added tests and fixed errors with the validation rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the tests pass, I think this is ready to merge!
…ge#1776, accessibility-exchange#1775, accessibility-exchange#1774, accessibility-exchange#1773, accessibility-exchange#1772) (accessibility-exchange#1820) * fix: update request validations and add tests * fix: engagement edit language field error message Also added tests and fixed errors with the validation rules. * fix: eng survey details missing inline errors * fix: failing engagement test * fix: engagement selection criteria validation * fix: meeting validation error messages * test: refactor validation tests * fix: update the validation messages * fix: typo for Indigenous group * style: remove duplicate array value * chore: update localization files
Resolves #1776
Resolves #1775
Resolves #1774
Resolves #1773
Resolves #1772
Additional Changes
Prerequisites
If this PR changes PHP code or dependencies:
composer format
and fixed any code formatting issues.composer analyze
and addressed any static analysis issues.php artisan test
and ensured that all tests pass.composer localize
to update localization source files and committed any changes.If this PR changes CSS or JavaScript code or dependencies:
npm run lint
and fixed any linting issues.npm run build
and ensured that CSS and JavaScript assets can be compiled.