Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various validation related issues (resolves #1776, #1775, #1774, #1773, #1772) #1820

Merged
merged 11 commits into from
Jun 27, 2023

Conversation

jobara
Copy link
Collaborator

@jobara jobara commented Jun 26, 2023

Resolves #1776
Resolves #1775
Resolves #1774
Resolves #1773
Resolves #1772

Additional Changes

  • Adds IdentityType enum
  • Adds LocationType enum
  • Adds validation tests (See Write tests for validation errors  #1813) for some of the request types
  • Addresses some runtime errors when invalid data passed to request
  • Updates validation error messages
  • Corrects some validation rules

Prerequisites

If this PR changes PHP code or dependencies:

  • I've run composer format and fixed any code formatting issues.
  • I've run composer analyze and addressed any static analysis issues.
  • I've run php artisan test and ensured that all tests pass.
  • I've run composer localize to update localization source files and committed any changes.

If this PR changes CSS or JavaScript code or dependencies:

  • I've run npm run lint and fixed any linting issues.
  • I've run npm run build and ensured that CSS and JavaScript assets can be compiled.

@jobara jobara added this to the 1.0.0 milestone Jun 26, 2023
@jobara jobara mentioned this pull request Jun 20, 2023
60 tasks
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #1820 (b8c7f7a) into dev (6dc89fe) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head b8c7f7a differs from pull request most recent head a7f7662. Consider uploading reports for the commit a7f7662 to get more accurate results

@@             Coverage Diff              @@
##                dev    #1820      +/-   ##
============================================
+ Coverage     96.47%   96.52%   +0.04%     
- Complexity     1984     2032      +48     
============================================
  Files           299      301       +2     
  Lines          8636     8746     +110     
============================================
+ Hits           8332     8442     +110     
  Misses          304      304              
Impacted Files Coverage Δ
app/Enums/IdentityType.php 100.00% <100.00%> (ø)
app/Enums/LocationType.php 100.00% <100.00%> (ø)
app/Http/Controllers/EngagementController.php 100.00% <100.00%> (ø)
app/Http/Requests/AddNotificationableRequest.php 100.00% <100.00%> (ø)
app/Http/Requests/AddTranslationRequest.php 100.00% <100.00%> (ø)
app/Http/Requests/DestroyTranslationRequest.php 100.00% <100.00%> (ø)
app/Http/Requests/MeetingRequest.php 100.00% <100.00%> (ø)
...pp/Http/Requests/RemoveNotificationableRequest.php 100.00% <100.00%> (ø)
app/Http/Requests/SaveIndividualRolesRequest.php 100.00% <100.00%> (ø)
app/Http/Requests/StoreInvitationRequest.php 100.00% <100.00%> (ø)
... and 4 more

Copy link
Collaborator

@greatislander greatislander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the tests pass, I think this is ready to merge!

@jobara jobara enabled auto-merge (squash) June 27, 2023 16:26
@jobara jobara merged commit 3ac30f4 into accessibility-exchange:dev Jun 27, 2023
6 checks passed
marvinroman pushed a commit to marvinroman/platform that referenced this pull request Jul 24, 2023
…ge#1776, accessibility-exchange#1775, accessibility-exchange#1774, accessibility-exchange#1773, accessibility-exchange#1772) (accessibility-exchange#1820)

* fix: update request validations and add tests

* fix: engagement edit language field error message

Also added tests and fixed errors with the validation rules.

* fix: eng survey details missing inline errors

* fix: failing engagement test

* fix: engagement selection criteria validation

* fix: meeting validation error messages

* test: refactor validation tests

* fix: update the validation messages

* fix: typo for Indigenous group

* style: remove duplicate array value

* chore: update localization files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants