Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: course styling and text updates (resolves #1870, #1872) #1873

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

jobara
Copy link
Collaborator

@jobara jobara commented Jul 25, 2023

Resolves #1870
Resolves #1872

  • Corrects module card typography to use an <h3> for the card heading
  • Corrects module cards layout to use a 2 column grid
  • Shortens the quiz's back button text

Prerequisites

If this PR changes PHP code or dependencies:

  • I've run composer format and fixed any code formatting issues.
  • I've run composer analyze and addressed any static analysis issues.
  • I've run php artisan test and ensured that all tests pass.
  • I've run composer localize to update localization source files and committed any changes.

If this PR changes CSS or JavaScript code or dependencies:

  • I've run npm run lint and fixed any linting issues.
  • I've run npm run build and ensured that CSS and JavaScript assets can be compiled.

@jobara jobara added this to the 1.1.0 milestone Jul 25, 2023
@jobara jobara enabled auto-merge (squash) July 25, 2023 12:39
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #1873 (778489a) into dev (5c9fd55) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #1873   +/-   ##
=========================================
  Coverage     96.28%   96.28%           
  Complexity     2033     2033           
=========================================
  Files           301      301           
  Lines          8756     8756           
=========================================
  Hits           8431     8431           
  Misses          325      325           

@jobara jobara merged commit c892b48 into accessibility-exchange:dev Jul 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Training module: Back button Training module: Typography
2 participants