-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: upgrade to Laravel 10.x (resolves #1906) #1928
Conversation
Note: I needed to upgrade to the development version of Larastan because of this issue: larastan/larastan#1547 (it's been fixed but not yet released) |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1928 +/- ##
============================================
+ Coverage 96.29% 96.42% +0.13%
Complexity 2033 2033
============================================
Files 301 301
Lines 8770 8766 -4
============================================
+ Hits 8445 8453 +8
+ Misses 325 313 -12
☔ View full report in Codecov by Sentry. |
fix: run Pint chore(deps-dev): add x-ray fix: replace template usage of SAFE_MARKDOWN_OPTIONS
@greatislander when I run I can however run |
@greatislander could you please also run the localization command? |
Co-authored-by: Justin Obara <jobara@users.noreply.github.com>
Yes. In fact I think it's probably a good idea to remove all references to |
test: remove unneeded --parallel flag test: recommend artisan test in docs
Also |
fix: move Markdown configuration to a config file
fix: use Laravel console output for seeder messages
chore(deps-dev): bump Pest and plugins to 2.x
chore(docs): replace references to Laravel 9.x
chore(docs): document using Mailpit (fix #1919)
chore(docs): document using Herd (fix #1920)
Prerequisites
If this PR changes PHP code or dependencies:
composer format
and fixed any code formatting issues.composer analyze
and addressed any static analysis issues.php artisan test
and ensured that all tests pass.composer localize
to update localization source files and committed any changes.If this PR changes CSS or JavaScript code or dependencies:
npm run lint
and fixed any linting issues.npm run build
and ensured that CSS and JavaScript assets can be compiled.