Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade to Laravel 10.x (resolves #1906) #1928

Merged
merged 24 commits into from
Oct 12, 2023

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Oct 10, 2023

fix: move Markdown configuration to a config file
fix: use Laravel console output for seeder messages
chore(deps-dev): bump Pest and plugins to 2.x
chore(docs): replace references to Laravel 9.x
chore(docs): document using Mailpit (fix #1919)
chore(docs): document using Herd (fix #1920)

Prerequisites

If this PR changes PHP code or dependencies:

  • I've run composer format and fixed any code formatting issues.
  • I've run composer analyze and addressed any static analysis issues.
  • I've run php artisan test and ensured that all tests pass.
  • I've run composer localize to update localization source files and committed any changes.

If this PR changes CSS or JavaScript code or dependencies:

  • I've run npm run lint and fixed any linting issues.
  • I've run npm run build and ensured that CSS and JavaScript assets can be compiled.

@greatislander
Copy link
Collaborator Author

Note: I needed to upgrade to the development version of Larastan because of this issue: larastan/larastan#1547 (it's been fixed but not yet released)

@greatislander greatislander marked this pull request as ready for review October 10, 2023 15:34
@greatislander greatislander self-assigned this Oct 10, 2023
@greatislander greatislander added dependencies Pull requests that update a dependency file php Pull requests that update PHP code labels Oct 10, 2023
@greatislander greatislander added this to the 1.2.0 milestone Oct 10, 2023
@greatislander greatislander linked an issue Oct 10, 2023 that may be closed by this pull request
1 task
@greatislander greatislander enabled auto-merge (squash) October 10, 2023 15:35
@greatislander greatislander enabled auto-merge (squash) October 10, 2023 15:35
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c18f216) 96.29% compared to head (5f40701) 96.42%.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1928      +/-   ##
============================================
+ Coverage     96.29%   96.42%   +0.13%     
  Complexity     2033     2033              
============================================
  Files           301      301              
  Lines          8770     8766       -4     
============================================
+ Hits           8445     8453       +8     
+ Misses          325      313      -12     
Files Coverage Δ
app/Console/Commands/SeederBackupData.php 0.00% <ø> (ø)
app/Http/Controllers/UserController.php 100.00% <ø> (ø)
app/Http/Livewire/AddEngagementConnector.php 100.00% <100.00%> (ø)
app/Http/Livewire/CollectionResources.php 95.83% <100.00%> (ø)
app/Http/Livewire/ManageEngagementConnector.php 79.54% <100.00%> (ø)
app/Models/Course.php 100.00% <ø> (ø)
app/Models/Engagement.php 97.74% <ø> (ø)
app/Models/Individual.php 100.00% <ø> (ø)
app/Models/Interpretation.php 100.00% <100.00%> (ø)
app/Models/Invitation.php 100.00% <100.00%> (ø)
... and 22 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greatislander greatislander enabled auto-merge (squash) October 11, 2023 00:53
phpunit.xml.dist Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tests/Feature/ProjectTest.php Outdated Show resolved Hide resolved
tests/Pest.php Outdated Show resolved Hide resolved
@jobara
Copy link
Collaborator

jobara commented Oct 11, 2023

@greatislander when I run composer test and composer test-coverage it fails due to a process timeout. And points at the documentation https://getcomposer.org/doc/06-config.md#process-timeout

I can however run php artisan test --coverage --parallel and it works. Have you experienced this?

README.md Outdated Show resolved Hide resolved
@jobara
Copy link
Collaborator

jobara commented Oct 11, 2023

@greatislander could you please also run the localization command?

Co-authored-by: Justin Obara <jobara@users.noreply.github.com>
@greatislander
Copy link
Collaborator Author

@greatislander when I run composer test and composer test-coverage it fails due to a process timeout. And points at the documentation getcomposer.org/doc/06-config.md#process-timeout

I can however run php artisan test --coverage --parallel and it works. Have you experienced this?

Yes. In fact I think it's probably a good idea to remove all references to composer test/composer test-coverage in favour of using the artisan commands. There are many benefits, including the fact that the artisan commands let you pass --filter and other params which I don't think the composer ones do.

test: remove unneeded --parallel flag
test: recommend artisan test in docs
@greatislander
Copy link
Collaborator Author

Also --parallel is no longer required, it's default in Pest 2.x.

@greatislander greatislander merged commit 6521017 into dev Oct 12, 2023
10 checks passed
@greatislander greatislander deleted the feat/upgrade-major-dependencies branch October 12, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file php Pull requests that update PHP code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Document using Herd for local development Switch from mailhog to mailpit Upgrade Laravel to 10.x
2 participants