Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automate resetting dev deploy (resolves #1902, #1903) #1935

Merged
merged 23 commits into from
Nov 14, 2023

Conversation

marvinroman
Copy link
Contributor

Creates a scheduled reset 15 minutes after midnight every day for the dev environment.

@marvinroman marvinroman linked an issue Oct 13, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (f344155) 96.66% compared to head (1aee83c) 96.59%.

Files Patch % Lines
app/Console/Commands/RefreshDev.php 0.00% 6 Missing ⚠️
app/Console/Commands/SeederBackupData.php 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1935      +/-   ##
============================================
- Coverage     96.66%   96.59%   -0.07%     
- Complexity     2062     2064       +2     
============================================
  Files           309      310       +1     
  Lines          8983     8996      +13     
============================================
+ Hits           8683     8690       +7     
- Misses          300      306       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

app/Console/Kernel.php Outdated Show resolved Hide resolved
app/Console/Kernel.php Outdated Show resolved Hide resolved
@marvinroman
Copy link
Contributor Author

@jobara for the failing tests I will reach out to you tomorrow with the variables that we need to add into Github for the tests to pass.

app/Console/Commands/RefreshDev.php Outdated Show resolved Hide resolved
app/Console/Kernel.php Outdated Show resolved Hide resolved
@jobara
Copy link
Collaborator

jobara commented Oct 26, 2023

@jobara for the failing tests I will reach out to you tomorrow with the variables that we need to add into Github for the tests to pass.

As discussed its preferable to not require the ENVs for use on GitHub and when running locally.

->timezone('America/Los_Angeles') // Run as PST timezone
->onOneServer(); // run only on a single server at once

$schedule->command('app:refresh-dev') // use custom hcommand to make sure that te commands are chained
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo "hcommand"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marvinroman this typo is still present.

database/seeders/IdentitySeeder.php Outdated Show resolved Hide resolved
database/seeders/ResourceSeeder.php Outdated Show resolved Hide resolved
Comment on lines 49 to 58
// fix for when it runs in environments without access to S3 bucket
// TODO remove after testing
// try {
// // try connecting to the seeds S3 bucket
// Storage::disk('seeds');
// } catch (\Exception $e) {
// // mock the seeds filesystem locally
// Storage::fake('seeds');
// }

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed?

->timezone('America/Los_Angeles') // Run as PST timezone
->onOneServer(); // run only on a single server at once

$schedule->command('app:refresh-dev') // use custom hcommand to make sure that te commands are chained
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marvinroman this typo is still present.

@jobara jobara changed the title 1902 automate resetting dev deploy feat: automate resetting dev deploy (resolves #1902, #1903) Nov 14, 2023
@jobara jobara enabled auto-merge (squash) November 14, 2023 15:36
@jobara jobara self-requested a review November 14, 2023 15:36
@jobara jobara merged commit 3237d0c into dev Nov 14, 2023
8 of 10 checks passed
@jobara jobara deleted the 1902-automate-resetting-dev-deploy branch November 14, 2023 15:36
@jobara
Copy link
Collaborator

jobara commented Nov 14, 2023

@marvinroman because the remaining changes were minor, I made them myself and merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Provide a mechanism for updating staging and dev with data from production Automate resetting Dev deploy
3 participants