-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automate resetting dev deploy (resolves #1902, #1903) #1935
Conversation
… instead of just finding correctly tagged json
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #1935 +/- ##
============================================
- Coverage 96.66% 96.59% -0.07%
- Complexity 2062 2064 +2
============================================
Files 309 310 +1
Lines 8983 8996 +13
============================================
+ Hits 8683 8690 +7
- Misses 300 306 +6 ☔ View full report in Codecov by Sentry. |
@jobara for the failing tests I will reach out to you tomorrow with the variables that we need to add into Github for the tests to pass. |
As discussed its preferable to not require the ENVs for use on GitHub and when running locally. |
app/Console/Kernel.php
Outdated
->timezone('America/Los_Angeles') // Run as PST timezone | ||
->onOneServer(); // run only on a single server at once | ||
|
||
$schedule->command('app:refresh-dev') // use custom hcommand to make sure that te commands are chained |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo "hcommand"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marvinroman this typo is still present.
// fix for when it runs in environments without access to S3 bucket | ||
// TODO remove after testing | ||
// try { | ||
// // try connecting to the seeds S3 bucket | ||
// Storage::disk('seeds'); | ||
// } catch (\Exception $e) { | ||
// // mock the seeds filesystem locally | ||
// Storage::fake('seeds'); | ||
// } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be removed?
app/Console/Kernel.php
Outdated
->timezone('America/Los_Angeles') // Run as PST timezone | ||
->onOneServer(); // run only on a single server at once | ||
|
||
$schedule->command('app:refresh-dev') // use custom hcommand to make sure that te commands are chained |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marvinroman this typo is still present.
@marvinroman because the remaining changes were minor, I made them myself and merged in. |
Creates a scheduled reset 15 minutes after midnight every day for the dev environment.