Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: robots and sitemap served at /storage path (resolves #1998) #2000

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

jobara
Copy link
Collaborator

@jobara jobara commented Nov 22, 2023

Resolves #1998

  • Adds symlinks for the sitemap and robots files into the public directory
  • Updates/cleans up tests

Prerequisites

If this PR changes PHP code or dependencies:

  • I've run composer format and fixed any code formatting issues.
  • I've run composer analyze and addressed any static analysis issues.
  • I've run php artisan test and ensured that all tests pass.
  • I've run composer localize to update localization source files and committed any changes.

If this PR changes CSS or JavaScript code or dependencies:

  • I've run npm run lint and fixed any linting issues.
  • I've run npm run build and ensured that CSS and JavaScript assets can be compiled.

@jobara jobara added this to the 1.2.2 milestone Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ca621e) 97.65% compared to head (5122836) 97.65%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #2000   +/-   ##
=========================================
  Coverage     97.65%   97.65%           
  Complexity     2055     2055           
=========================================
  Files           314      314           
  Lines          8991     8991           
=========================================
  Hits           8780     8780           
  Misses          211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@greatislander greatislander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on the issue by mistake:

#1998 (comment)
#1998 (comment)

@jobara
Copy link
Collaborator Author

jobara commented Nov 22, 2023

I commented on the issue by mistake:

#1998 (comment) #1998 (comment)

Regarding the links, they are being run in the deployed environment and I ran them locally. I also went into the deploy server and tried to run them again, but it said it was already done.

Are you thinking of adding a symlink from storage into the public path? I guess we could try that too, although the files would be accessible at /robots.txt and /storage/robots.txt although I guess that isn't a huge issue.

Copy link
Collaborator

@greatislander greatislander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add additional links in config/filesystems.php:

        public_path('sitemap.xml') => storage_path('app/public/sitemap.xml'),
        public_path('robots.txt') => storage_path('app/public/robots.txt'),

@chosww
Copy link
Collaborator

chosww commented Nov 22, 2023

Thanks @jobara, using links as @greatislander suggested looks great 👍

@jobara jobara merged commit d6d1d5e into accessibility-exchange:dev Nov 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

On the deployed sites robots.txt and sitemap.xml are served under the /storage path
3 participants