-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: robots and sitemap served at /storage path (resolves #1998) #2000
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2000 +/- ##
=========================================
Coverage 97.65% 97.65%
Complexity 2055 2055
=========================================
Files 314 314
Lines 8991 8991
=========================================
Hits 8780 8780
Misses 211 211 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented on the issue by mistake:
Regarding the links, they are being run in the deployed environment and I ran them locally. I also went into the deploy server and tried to run them again, but it said it was already done. Are you thinking of adding a symlink from storage into the public path? I guess we could try that too, although the files would be accessible at /robots.txt and /storage/robots.txt although I guess that isn't a huge issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add additional links in config/filesystems.php
:
public_path('sitemap.xml') => storage_path('app/public/sitemap.xml'),
public_path('robots.txt') => storage_path('app/public/robots.txt'),
Thanks @jobara, using links as @greatislander suggested looks great 👍 |
Resolves #1998
Prerequisites
If this PR changes PHP code or dependencies:
composer format
and fixed any code formatting issues.composer analyze
and addressed any static analysis issues.php artisan test
and ensured that all tests pass.composer localize
to update localization source files and committed any changes.If this PR changes CSS or JavaScript code or dependencies:
npm run lint
and fixed any linting issues.npm run build
and ensured that CSS and JavaScript assets can be compiled.