feat: symlink lsq translations from fr translations (resolves #1990) #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2002 +/- ##
=========================================
Coverage 97.65% 97.65%
Complexity 2055 2055
=========================================
Files 314 314
Lines 8991 8991
=========================================
Hits 8780 8780
Misses 211 211 ☔ View full report in Codecov by Sentry. |
chosww
reviewed
Nov 22, 2023
| 'forgot_intro' => 'Mot de passe oublié? Entrez votre adresse e-mail et nous vous enverrons par e-mail un lien de réinitialisation du mot de passe qui vous permettra d’en choisir un nouveau.', | ||
| 'forgot_submit' => 'Envoyer le lien de réinitialisation', | ||
| 'reset_submit' => 'Réinitialiser le mot de passe', | ||
| 'verification_required' => 'Vérification de l\'e-mail requise', |
There was a problem hiding this comment.
I see that we escaped a single quote here, but could we make the same update we did for the single quote in Hearth as well?
There was a problem hiding this comment.
Yes, I guess we could do that.
chosww
approved these changes
Nov 22, 2023
chosww
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1990
composer localizescript to not copy fr to lsqPrerequisites
If this PR changes PHP code or dependencies:
composer formatand fixed any code formatting issues.composer analyzeand addressed any static analysis issues.php artisan testand ensured that all tests pass.composer localizeto update localization source files and committed any changes.If this PR changes CSS or JavaScript code or dependencies:
npm run lintand fixed any linting issues.npm run buildand ensured that CSS and JavaScript assets can be compiled.