Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: course seeder not run in production (resolves #2013) #2025

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

jobara
Copy link
Collaborator

@jobara jobara commented Nov 29, 2023

Resolves #2013

  • Moves model related seeders to be called by the DatabaseSeeder
  • Removes the ProductionSeeder as it no longer has any extra functionality over the DatabaseSeeder

Prerequisites

If this PR changes PHP code or dependencies:

  • I've run composer format and fixed any code formatting issues.
  • I've run composer analyze and addressed any static analysis issues.
  • I've run php artisan test and ensured that all tests pass.
  • I've run composer localize to update localization source files and committed any changes.

If this PR changes CSS or JavaScript code or dependencies:

  • I've run npm run lint and fixed any linting issues.
  • I've run npm run build and ensured that CSS and JavaScript assets can be compiled.

BEGIN_COMMIT_OVERRIDE
fix: course seeder not run in production (resolves #2013) #2025
END_COMMIT_OVERRIDE

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4ffdc3) 97.65% compared to head (4218ce8) 97.65%.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #2025   +/-   ##
=========================================
  Coverage     97.65%   97.65%           
  Complexity     2055     2055           
=========================================
  Files           314      314           
  Lines          8991     8991           
=========================================
  Hits           8780     8780           
  Misses          211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jobara jobara merged commit 59004ee into accessibility-exchange:dev Nov 30, 2023
9 checks passed
@michelled michelled added this to the 1.2.4 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Course seeder should be added with the Production seeder
3 participants