-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: model lsq translations don't fallback to fr (resolves #2014, #2026, #2028, #2029) #2027
Conversation
@greatislander in fixing the failing test I realized that I may have removed some functionality, but I'm also not sure how that part was supposed to work or if it was actually functional on the site. I wonder if you could weigh in. Basically I removed the language bits from the controllers. It looks like you could use that to pass in a query parameter to have an individual or organization public page rendered in an alternative language if one was provided. However, I don't see how a user could have specified that query parameter. Am I understanding this correctly? Have I missed something? Is this still needed? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #2027 +/- ##
============================================
- Coverage 97.63% 97.60% -0.03%
+ Complexity 2105 2101 -4
============================================
Files 314 313 -1
Lines 9497 9522 +25
============================================
+ Hits 9272 9294 +22
- Misses 225 228 +3 ☔ View full report in Codecov by Sentry. |
I spoke with @greatislander about this. The While the written language supports from HasMultimodalTranslations isn't required any more, the rough in for the ASL/LSQ upload options is still requested to remain, in case we implement those features in the future (See: #455). |
While reviewing this, @greatislander found two other bugs ( #2029, #2028 ). If possible these should be addressed alongside this one. |
app/helpers.php
Outdated
use Illuminate\Support\Arr; | ||
use Illuminate\Support\Facades\Route as FacadesRoute; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd call this RouteFacade
instead.
Resolves #2014
Resolves #2026
Resolves #2028
Resolves #2029
get_written_language_for_signed_language
toto_written_language
localized_route_for_locale
helperroute_name
helpermissingKeyCallback
to fallback lsq to frPrerequisites
If this PR changes PHP code or dependencies:
composer format
and fixed any code formatting issues.composer analyze
and addressed any static analysis issues.php artisan test
and ensured that all tests pass.composer localize
to update localization source files and committed any changes.If this PR changes CSS or JavaScript code or dependencies:
npm run lint
and fixed any linting issues.npm run build
and ensured that CSS and JavaScript assets can be compiled.BEGIN_COMMIT_OVERRIDE
fix: model lsq translations don't fallback to fr (resolves #2014, #2026) (#2027)
fix: rendering of language changer links (resolves #2028, #2029) (#2027)
fix: response time in other languages not saved (#2027)
fix: can't add other engagement languages (#2027)
fix: not displaying content in translation (#2027)
END_COMMIT_OVERRIDE