Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pagination throws error (resolves #2045) #2046

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

jobara
Copy link
Collaborator

@jobara jobara commented Dec 4, 2023

Resolves #2045

Removes use of numberOfPaginatorsRendered as this was removed from Livewire 3.

See: livewire/livewire@a81b6fd

Prerequisites

If this PR changes PHP code or dependencies:

  • I've run composer format and fixed any code formatting issues.
  • I've run composer analyze and addressed any static analysis issues.
  • I've run php artisan test and ensured that all tests pass.
  • I've run composer localize to update localization source files and committed any changes.

If this PR changes CSS or JavaScript code or dependencies:

  • I've run npm run lint and fixed any linting issues.
  • I've run npm run build and ensured that CSS and JavaScript assets can be compiled.

BEGIN_COMMIT_OVERRIDE
fix: pagination throws error (resolves #2045) #2046
END_COMMIT_OVERRIDE

@jobara jobara added this to the 1.2.4 milestone Dec 4, 2023
@jobara jobara requested a review from chosww December 4, 2023 16:36
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (59004ee) 97.65% compared to head (77f62a7) 97.65%.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #2046   +/-   ##
=========================================
  Coverage     97.65%   97.65%           
  Complexity     2055     2055           
=========================================
  Files           314      314           
  Lines          8991     8991           
=========================================
  Hits           8780     8780           
  Misses          211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@chosww chosww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jobara, seems like removing the lines would resolve the issue notified by Flare; however, are the logics in removed lines not needed?

@jobara jobara enabled auto-merge (squash) December 4, 2023 16:53
@jobara
Copy link
Collaborator Author

jobara commented Dec 4, 2023

Thanks @jobara, seems like removing the lines would resolve the issue notified by Flare; however, are the logics in removed lines not needed?

Not anymore. I added a link in the description to the commit it was removed from Livewire. It had been a workaround.

@chosww chosww self-requested a review December 4, 2023 16:58
@jobara jobara merged commit 4484241 into accessibility-exchange:dev Dec 4, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Property [$numberOfPaginatorsRendered] not found on component: [manage-accounts]
2 participants