-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: localize notifications properly (resolves #2015, #2012) #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2050 +/- ##
=========================================
Coverage 97.62% 97.63%
- Complexity 2103 2105 +2
=========================================
Files 314 314
Lines 9482 9497 +15
=========================================
+ Hits 9257 9272 +15
Misses 225 225 ☔ View full report in Codecov by Sentry. |
This was
linked to
issues
Dec 6, 2023
This was referenced Dec 6, 2023
jobara
changed the title
fix: localize notifications properly
fix: localize notifications properly (resolves #2015, #2012)
Dec 7, 2023
jobara
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issues described in #2015 and #2012.
The issue with 2015 was that we notify users differently based on whether they are a member of an organization or the owner of the organization in ManageOrganizationalAccount. Whenever notification is sent to an organization, we loop through each members then use notify on the users, but organization owners get notification to their account. Problem was that User model has preferredLocale set, so they were receiving emails in correct locale, but Organization or RegulatedOrganization model doesn't have preferredLocale set, so they were receiving emails based on the Admin's locale when the admin is performing some action to the organization's account.
Also, we were using built-in messages from Laravel Framework for email verification, and those strings were not localized. This PR customized email verification messages through AuthServiceProvider as instructed in https://laravel.com/docs/10.x/verification.
Prerequisites
If this PR changes PHP code or dependencies:
composer format
and fixed any code formatting issues.composer analyze
and addressed any static analysis issues.php artisan test
and ensured that all tests pass.composer localize
to update localization source files and committed any changes.If this PR changes CSS or JavaScript code or dependencies:
npm run lint
and fixed any linting issues.npm run build
and ensured that CSS and JavaScript assets can be compiled.