fix(win) Normalize Windows path before writing models to disk

Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
accordproject · Oct 17, 2019 · 5ce537b · 5ce537b
1 parent 2930a3a
commit 5ce537b
Show file tree

Hide file tree

Showing 3 changed files with 49 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/concerto-core/lib/modelmanager.js b/packages/concerto-core/lib/modelmanager.js
@@ -16,6 +16,7 @@
 
 const fs = require('fs');
 const fsPath = require('path');
+const slash = require('slash');
 
 const DefaultModelFileLoader = require('./introspect/loaders/defaultmodelfileloader');
 const Factory = require('./factory');
@@ -394,7 +395,8 @@ class ModelManager {
             if (file.isExternal() && !opts.includeExternalModels) {
                 return;
             }
-            const filename = file.fileName.split(fsPath.sep).pop();
+            // Always assume file names have been normalized from `\` to `/`
+            const filename = slash(file.fileName).split('/').pop();
             fs.writeFileSync(path + fsPath.sep + filename, file.definitions);
         });
     }

diff --git a/packages/concerto-core/package.json b/packages/concerto-core/package.json
@@ -68,6 +68,7 @@
     "jsome": "2.5.0",
     "lorem-ipsum": "1.0.6",
     "moment-mini": "2.22.1",
+    "slash": "3.0.0",
     "triple-beam": "1.3.0",
     "urijs": "1.19.1",
     "uuid": "3.3.2",