class-declaration-abstractness-changed

accordproject · Dec 21, 2024 · eb1fde0 · eb1fde0
1 parent 85366be
commit eb1fde0
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/packages/concerto-analysis/src/comparers/class-declarations.ts b/packages/concerto-analysis/src/comparers/class-declarations.ts
@@ -54,11 +54,17 @@ const classDeclarationTypeChanged: ComparerFactory = (context) => ({
         if (aType === bType) {
             return;
         }
-        context.report({
-            key: 'class-declaration-type-changed',
-            message: `The ${aType} "${a.getName()}" changed type from ${aType} to ${bType}`,
-            element: a
-        });
+
+        const isAbstract = (declaration) => declaration.isAbstract();
+        if (isAbstract(a) !== isAbstract(b)) {
+            const changeType = isAbstract(a) ? 'abstract to concrete' : 'concrete to abstract';
+            const changeSeverity = isAbstract(a) ? 'minor' : 'major';
+            context.report({
+                key: 'class-declaration-abstractness-changed',
+                message: `The class "${a.getName()}" changed from ${changeType} (${changeSeverity} change).`,
+                element: a
+            });
+        }
     }
 });