Underline Text in List

[Michael-Grover]

The underline style can not be applied to text in an ordered or unordered list. The bold, italic, and code styles work for text in a list.

Example of a real contract where parts of an ordered list are underlined, which currently isn't possible in our editor:

[dselman]

Markdown doesn't natively support underline, so we need to rethink how we serialise this. I suggest we remove the underline option for now, and then experiment with using html tags for underline.

[nitinsultania]

in paragraph tag we can use this
style="text-decoration: underline;"

[jolanglinais]

This issue is linked with accordproject/markdown-editor#98

[jolanglinais]

in paragraph tag we can use this
style="text-decoration: underline;"

I believe this won't exactly work due to how we are handling transforming markdown to ciceromark to commonmark to slate (diagram).

[jeromesimeon]

in paragraph tag we can use this
style="text-decoration: underline;"

I believe this won't exactly work due to how we are handling transforming markdown to ciceromark to commonmark to slate (diagram).

We need to figure out how (whether?) we should represent underline in markdown first (See @dselman 's comment).

Is this a must have feature?

[K-Kumar-01]

@irmerk
Can we use <ins> HTML tag for this purpose. I used it on template-dingus and it worked there

Though I am not sure about this but as we will wrap the text in HTML I don't think it would cause any issue as it is supported by markdown itself.

[jolanglinais]

I'm unsure about this, because our markdown-transform will likely lose this formatting when roundtripping through markdown - which does not support it. Thoughts @dselman @jeromesimeon ?

[jeromesimeon]

We shouldn't depend too much on HTML tags since we convert contracts to other formats: e.g., pdf, docx. It would be better to use a proper underline extension as @dselman suggested in a previous comment.

For instance: https://www.npmjs.com/package/markdown-it-plugin-underline

Not sure underline is our most pressing requirement though.

[K-Kumar-01]

@jeromesimeon @irmerk
Since the priority is not pressing I would have a go at other issues then.

[Hanaffi]

@irmerk Can you assign this to me please?

[jeromesimeon]

@irmerk Can you assign this to me please?

As you can see from the thread. We're not really pursuing this feature at the moment.

[Hanaffi]

@jeromesimeon Oh no.
Can you assign some issue to me? (For ex. #73)
Every time I find an issue, Its assigned to someone or has low priority.

[jolanglinais]

If there aren't any open Issues that are open and not low priority, then there aren't any. Something as challenging as #73 won't be assigned to someone without having a pretty thorough investigation into what we need to do and how.

[Michael-Grover]

This issue is out of date. The tech working group is currently looking into adding underlined text to the markdown editor.

[jolanglinais]

Related to (blocked by if we want to pursue this) accordproject/markdown-transform#368