-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsx/Form.js] new radio component! #5279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool! one request i have is to swap the radios and labels so that the label comes after the radio button. like the first example here
Hi @zaliqarosli, I added the requested changes and it's ready for review again. Thank you for the help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks alizee! looks good!
This has conflicts since the Slider one was merged. |
Hi @driusan, I fixed the conflicts. |
i think this needs to be rebased to major? or is it master @ridz1208? |
@zaliqarosli I would refrain from doing any rebasing right now. the branches will be shifted around once the release is out. |
@zaliqarosli Please see #5846. Trouble rebasing and so I made a new PR. |
Brief summary of changes
<RadioElement/>
Note: I kept the design simple for now.
Preview:
Links to related tickets (GitHub, Redmine, ...)
Testing instructions (if applicable)
Example replace modules/new_profile/jsx/NewProfileIndex.js with: