-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsx/Form.js] new slider component! #5280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltheism
added
Feature
PR or issue introducing/requiring at least one new feature
UI
PR or issue introducing/requiring improvements to the LORIS User Interface
labels
Oct 4, 2019
This was referenced Oct 4, 2019
zaliqarosli
previously requested changes
Oct 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise, everything else looks good! :)
zaliqarosli
reviewed
Oct 7, 2019
Hi @zaliqarosli, I added the changes requested and it's ready for review again. Let me know if I missed something or anything comes to mind. |
zaliqarosli
reviewed
Oct 15, 2019
zaliqarosli
approved these changes
Oct 21, 2019
zaliqarosli
added
the
Passed Manual Tests
PR has undergone proper testing by at least one peer
label
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature
PR or issue introducing/requiring at least one new feature
Passed Manual Tests
PR has undergone proper testing by at least one peer
UI
PR or issue introducing/requiring improvements to the LORIS User Interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
<SliderElement/>
Note: I kept the design simple for now.
Preview:
Links to related tickets (GitHub, Redmine, ...)
Testing instructions (if applicable)
Example replace modules/new_profile/jsx/NewProfileIndex.js with: