-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build by adding /v4 to module path #260
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ builds: | |
post: | ||
- upx "{{ .Path }}" | ||
ldflags: | ||
- -s -w -X 'github.com/achannarasappa/ticker/cmd.Version={{.Version}}' | ||
- -s -w -X 'github.com/achannarasappa/ticker/v4/cmd.Version={{.Version}}' | ||
- id: build-linux | ||
main: ./main.go | ||
env: | ||
|
@@ -30,7 +30,7 @@ builds: | |
post: | ||
- upx "{{ .Path }}" | ||
ldflags: | ||
- -s -w -X 'github.com/achannarasappa/ticker/cmd.Version={{.Version}}' | ||
- -s -w -X 'github.com/achannarasappa/ticker/v4/cmd.Version={{.Version}}' | ||
- id: build | ||
main: ./main.go | ||
env: | ||
|
@@ -39,7 +39,7 @@ builds: | |
- windows | ||
- darwin | ||
ldflags: | ||
- -s -w -X 'github.com/achannarasappa/ticker/cmd.Version={{.Version}}' | ||
- -s -w -X 'github.com/achannarasappa/ticker/v4/cmd.Version={{.Version}}' | ||
archives: | ||
- | ||
name_template: "{{ .ProjectName }}-{{ .Version }}-{{ .Os }}-{{ .Arch }}{{ if .Arm }}v{{ .Arm }}{{ end }}{{ if .Mips }}-{{ .Mips }}{{ end }}" | ||
|
@@ -62,7 +62,7 @@ brews: | |
commit_author: | ||
name: achannarasappa | ||
email: git@ani.dev | ||
homepage: "https://github.com/achannarasappa/ticker" | ||
homepage: "https://github.com/achannarasappa/ticker/v4" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This URL should remain without a |
||
description: "Terminal stock ticker with live updates and position tracking" | ||
license: "GPLv3" | ||
dockers: | ||
|
@@ -115,7 +115,7 @@ nfpms: | |
file_name_template: "{{ .ProjectName }}-{{ .Version }}-{{ .Os }}-{{ .Arch }}{{ if .Arm }}v{{ .Arm }}{{ end }}{{ if .Mips }}-{{ .Mips }}{{ end }}" | ||
builds: | ||
- build-linux-64 | ||
homepage: https://github.com/achannarasappa/ticker | ||
homepage: https://github.com/achannarasappa/ticker/v4 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This URL should remain without a |
||
maintainer: Ani Channarasappa <ticker@ani.dev> | ||
description: Terminal stock ticker with live updates and position tracking | ||
license: GPLv3 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
<p> | ||
<a href="https://github.com/achannarasappa/ticker/releases"><img src="https://img.shields.io/github/v/release/achannarasappa/ticker" alt="Latest Release"></a> | ||
<a href="https://github.com/achannarasappa/ticker/actions"><img src="https://github.com/achannarasappa/ticker/workflows/test/badge.svg" alt="Build Status"></a> | ||
<a href="https://github.com/achannarasappa/ticker/v4/releases"><img src="https://img.shields.io/github/v/release/achannarasappa/ticker" alt="Latest Release"></a> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. URLs in the readme should remain without a |
||
<a href="https://github.com/achannarasappa/ticker/v4/actions"><img src="https://github.com/achannarasappa/ticker/v4/workflows/test/badge.svg" alt="Build Status"></a> | ||
<a href='https://coveralls.io/github/achannarasappa/ticker?branch=master'><img src='https://coveralls.io/repos/github/achannarasappa/ticker/badge.svg?branch=master' alt='Coverage Status' /></a> | ||
<a href='https://goreportcard.com/badge/github.com/achannarasappa/ticker'><img src='https://goreportcard.com/badge/github.com/achannarasappa/ticker' alt='Report Card' /></a> | ||
<a href='https://goreportcard.com/badge/github.com/achannarasappa/ticker/v4'><img src='https://goreportcard.com/badge/github.com/achannarasappa/ticker/v4' alt='Report Card' /></a> | ||
</p> | ||
|
||
<h1 align="center">Ticker</h2> | ||
|
@@ -22,7 +22,7 @@ Terminal stock watcher and stock position tracker | |
|
||
## Install | ||
|
||
Download the pre-compiled binaries from the [releases page](https://github.com/achannarasappa/ticker/releases) and copy to a location in `PATH` or see quick installs below | ||
Download the pre-compiled binaries from the [releases page](https://github.com/achannarasappa/ticker/v4/releases) and copy to a location in `PATH` or see quick installs below | ||
|
||
**homebrew** | ||
``` | ||
|
@@ -160,7 +160,7 @@ Watchlists and holdings can be grouped in `.ticker.yml` under the `groups` prope | |
|
||
* *none* - symbols with no suffix will default to Yahoo Finance as the data source | ||
* `.X` - symbols with this suffix are shorthand symbols that are specific to ticker and intended to provide more concise and familiar symbols for popular assets (e.g. using `SOL.X` rather than `SOLANA.CG`) | ||
* The full list of ticker symbols can be found [here](https://github.com/achannarasappa/ticker-static/blob/master/symbols.csv). Initial values are populated with the top 250 cryptocurrencies from CoinGecko at time of release | ||
* The full list of ticker symbols can be found [here](https://github.com/achannarasappa/ticker/v4-static/blob/master/symbols.csv). Initial values are populated with the top 250 cryptocurrencies from CoinGecko at time of release | ||
* `.CG` - symbols with this suffix will use CoinGecko as the data source. The proper coin name can be found on the CoinGecko page in the *API id* field (e.g. for `SOL` go to the coin's [page on CoinGecko](https://www.coingecko.com/en/coins/solana), find the value is `solana`, and use the symbol `SOLANA.CG` in ticker) | ||
|
||
### Currency Conversion | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
module github.com/achannarasappa/ticker | ||
module github.com/achannarasappa/ticker/v4 | ||
|
||
go 1.18 | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure these should remain with a
/v4/
but not certain. Have you run a test build to confirm this should be here?