refactor: dont use a magic string for USER_BASE_URL in tests

achievements-app · Oct 18, 2022 · 4f1a501 · 4f1a501 · vercel · Oct 18, 2022
1 parent 3793a57
commit 4f1a501
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/src/user/getProfileFromAccountId.test.ts b/src/user/getProfileFromAccountId.test.ts
@@ -6,6 +6,7 @@ import type {
   ProfileFromAccountIdResponse
 } from "../models";
 import { getProfileFromAccountId } from "./getProfileFromAccountId";
+import { USER_BASE_URL } from "./USER_BASE_URL";
 
 const server = setupServer();
 
@@ -71,12 +72,9 @@ describe("Function: getProfileFromUserName", () => {
     };
 
     server.use(
-      rest.get(
-        "https://m.np.playstation.com/api/userProfile/v1/internal/users/111222333444/profiles",
-        (_, res, ctx) => {
-          return res(ctx.json(mockResponse));
-        }
-      )
+      rest.get(`${USER_BASE_URL}/111222333444/profiles`, (_, res, ctx) => {
+        return res(ctx.json(mockResponse));
+      })
     );
 
     // ASSERT

diff --git a/src/user/getUserFriendsAccountIds.test.ts b/src/user/getUserFriendsAccountIds.test.ts
@@ -6,6 +6,7 @@ import type {
   GetUserFriendsAccountIdsResponse
 } from "../models";
 import { getUserFriendsAccountIds } from "./getUserFriendsAccountIds";
+import { USER_BASE_URL } from "./USER_BASE_URL";
 
 const server = setupServer();
 
@@ -32,12 +33,9 @@ describe("Function: getUserFriendsAccountIds", () => {
     };
 
     server.use(
-      rest.get(
-        "https://m.np.playstation.com/api/userProfile/v1/internal/users/me/friends",
-        (_, res, ctx) => {
-          return res(ctx.json(mockResponse));
-        }
-      )
+      rest.get(`${USER_BASE_URL}/me/friends`, (_, res, ctx) => {
+        return res(ctx.json(mockResponse));
+      })
     );
 
     // ACT