Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add avro method to Metadata #15

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Add avro method to Metadata #15

merged 5 commits into from
Oct 16, 2023

Conversation

minionOfZuul
Copy link
Contributor

@minionOfZuul minionOfZuul commented Oct 16, 2023 •
edited
Loading

This PR

  • Adds avro to the list of possible Attribute names
  • field_struct_avro_schema will read metadata out of this attribute to do things like match up sensitive data fields with a KMS key (via avro_acima)
  • Changes the call to AttributeMethods#attribute in metadata.rb:19 to spread the options hash into kwargs for ruby 3 compat

aemadrid
aemadrid requested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@aemadrid aemadrid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. We do need to change the version too though.

@minionOfZuul minionOfZuul mentioned this pull request Oct 16, 2023
Merged
@aemadrid aemadrid merged commit fa7b0f3 into master Oct 16, 2023
4 checks passed
@minionOfZuul minionOfZuul deleted the zach/add_avro_metadata branch October 17, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aemadrid aemadrid aemadrid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minionOfZuul @aemadrid