-
Notifications
You must be signed in to change notification settings - Fork 287
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'master' into python-dev
- Loading branch information
Showing
362 changed files
with
100,870 additions
and
5,396 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
1. [ ] In the Github sidebar, add the PR to work items and the current milestone | ||
1. [ ] In the Github sidebar, under "Development", make sure to link to the corresponding issue | ||
1. [ ] Make sure the branch is merged with the latest `master` branch | ||
1. [ ] Ensure that there are editors listed in the `<meta>` block | ||
1. [ ] For workshops, add a `<venue>ws</venue>` tag to its meta block | ||
1. [ ] For workshops, add a backlink from the main event's `<event>` block | ||
1. [ ] Add events to their relevant SIGs | ||
1. [ ] Look at the venue listing for prior years, and ensure that the new volume titles are consistent. You can do this by clicking on the venue name from a paper page, which will take you to the vendor listing. | ||
1. [ ] Navigate to the event page preview (e.g., https://preview.aclanthology.org/icnlsp-ingestion/events/icnlsp-2021/), and page through, to see if there are any glaring mistakes | ||
1. [ ] Skim through the complete listing, looking for mis-parsed author names. | ||
1. [ ] Download the frontmatter and verify that the table of contents matches at least three randomly-selected papers | ||
1. [ ] Download 3–5 PDFs (including the first and last one) and make sure they are correct (title, authors, page numbers). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
name: link-to-checklist | ||
|
||
on: | ||
workflow_dispatch: | ||
pull_request_target: | ||
types: [opened] | ||
|
||
jobs: | ||
add-review-checklist: | ||
if : ${{ github.event_name == 'pull_request_target' && github.event.action == 'opened' && startsWith(github.event.pull_request.title, 'ingestion') == true}} | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Check out repository | ||
uses: actions/checkout@v3 | ||
- name: Print event details | ||
run: | | ||
echo "Event Name: ${{ github.event_name }}" | ||
echo "Action: ${{ github.event.action }}" | ||
echo "PR Title: ${{ github.event.pull_request.title }}" | ||
echo "Starts with ingestion: ${{ startsWith(github.event.pull_request.title, 'ingestion') }}" | ||
- name: Log from GitHub script | ||
uses: actions/github-script@v6 | ||
with: | ||
script: | | ||
console.log('This is a test log.'); | ||
console.log('Event Name:', context.eventName); | ||
console.log('Action:', context.payload.action); | ||
console.log('PR Title:', context.payload.pull_request.title); | ||
console.log('Starts with ingestion:', context.payload.pull_request.title.startsWith('ingestion')); | ||
- name: Add review checklist | ||
uses: actions/github-script@v6 | ||
with: | ||
script: | | ||
const fs = require('fs'); | ||
console.log('Reading checklist file...'); | ||
const review_checklist = fs.readFileSync('.github/ingestion-review-checklist.md', 'utf8'); | ||
const old_description = context.payload.pull_request.body || ''; | ||
console.log('Old description:', old_description); | ||
const updated_body = !old_description.trim() ? review_checklist : old_description + "\n\n" + review_checklist; | ||
github.rest.pulls.update({ | ||
pull_number: context.issue.number, | ||
owner: context.repo.owner, | ||
repo: context.repo.repo, | ||
body: updated_body, | ||
}); | ||
console.log('Updated body:', updated_body); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
name: print-info | ||
|
||
on: | ||
workflow_dispatch: | ||
pull_request_target: | ||
types: [opened] | ||
|
||
jobs: | ||
add-review-checklist: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Print event details | ||
run: | | ||
echo "Event Name: ${{ github.event_name }}" | ||
echo "Action: ${{ github.event.action }}" | ||
echo "PR Title: ${{ github.event.pull_request.title }}" | ||
echo "Original PR Body: ${{ github.event.pull_request.body }}" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.