-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed comments from XML #2763
base: master
Are you sure you want to change the base?
Conversation
Build successful. Some useful links:
This preview will be removed when the branch is merged. |
These notes are intended to work more like groupings, right? Maybe we could do <colocated group="unsorted">
...
</colocated>
<colocated group="acl-2023">
...
</colocated> Alternatively, do you foresee this being used for anything other than |
This is very clearly a better way to do this, thanks! It is only for workshops. I've had requests from senior people to maintain the workshop listing, since it's useful for people to browse. It's a bit of a pain to update this list, and to keep it sorted, which is why I've been pushing for this grouping idea. Definitely open to re-factoring; did you have something in mind? |
Firstly, rather than creating a hypothetical event called Secondly, if that's how it's represented, it could be refactored in a number of ways, e.g. (i) replacing In any case, adapting the build so that everything marked as a workshop is compiled on its own page (which being part of the "ws" venue does now) should be a simple change. |
In #1117, we discussed adding a "workshop" flag to venues, but I think it's clearer to attach it to volumes, as this both mirrors how it currently works and avoids the issue of workshop venues turning into full conferences at some point. (On this note, there are a couple of volumes in the current "ws-2023" list that do say "conference" in the proceedings title — is this intentional?) |
The distinction between workshop/conference can be fuzzy. I think thought that *SEM, IWSLT, etc should not be listed under the workshops event. I suspect they were just blindly copied over along with all other colocated events. You're right in pointing out that we currently have redundant ways to add to the workshop "event". I'm not sure why I didn't see that and instead created the So if we go through with this, I guess the proposal is to eliminate all files of the format |
Noticing these types of issues might be easier when workshops are flagged within the volume itself, I think.
We can start by treating "workshop tags" the same as before during the build, i.e., creating the virtual "ws" venue and attaching these volumes to it. That should mean that on the front-end, everything stays the same. The question of how to do this better is then probably related to a redesign of the front page.
XPath expressions work: ~/r/acl-anthology/data/xml $ cat ?19.xml | xq -x '//meta[venue="ws"]/url' [09:33:53]
D19-51
D19-54
D19-58
D19-59
D19-60
D19-61
D19-63
D19-64
D19-66
W19-03
W19-11
W19-56
W19-68
W19-70
W19-71
W19-72
W19-73
W19-85 And we could add functionality to the new library that'll make this easy too.
Yes, and also:
For the build, I'd just turn |
I removed comments from the XML and the Python code that permitted skipping them when parsing. In its place, I added a "note" attribute to
<volume-id>
to help sort workshops. Would this work or does it also complicate things?