Fix allfeatvalues

aclai-lab · Dec 4, 2024 · d8d9b06 · d8d9b06
1 parent e56a684
commit d8d9b06
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/src/dimensional-structures/logiset.jl b/src/dimensional-structures/logiset.jl
@@ -447,7 +447,8 @@ end
 function allfeatvalues(
     X::UniformFullDimensionalLogiset,
 )
-    unique(X.featstruct)
+    error("TODO only look at upper half")
+    vec(X.featstruct)
 end
 
 function allfeatvalues(
@@ -461,12 +462,20 @@ end
 function allfeatvalues(
     X::UniformFullDimensionalLogiset,
     i_instance,
-    f,
+    f::AbstractFeature,
 )
     return error("Please, provide method allfeatvalues(::" *
         "$(typeof(X)), i_instance::$(typeof(i_instance)), f::$(typeof(f))).")
 end
 
+function allfeatvalues(
+    X::UniformFullDimensionalLogiset,
+    f::AbstractFeature,
+)
+    return error("Please, provide method allfeatvalues(::" *
+        "$(typeof(X)), f::$(typeof(f))).")
+end
+
 ############################################################################################
 
 function instances(