This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
fix and test software triggering #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nclack
changed the title
nclack
added a commit
to acquire-project/acquire-video-runtime
that referenced
this pull request
Aug 7, 2023
Fixes an unchecked failure in `acquire_map_read()` caused when a caller fails to call `acquire_unmap_read()` at the right time. For example: ```c acquire_map_read(runtime,0,&beg,&end); // When end>beg acquire_map_read(runtime,0,beg,end); // Should return AcquireStatus_Error ``` whereas ```c acquire_map_read(runtime,0,&beg,&end); // When end>beg acquire_unmap_read(runtime,0,&beg,&end); acquire_map_read(runtime,0,beg,end); // Should return AcquireStatus_Ok ``` acquire-project/acquire-driver-common#34 depends on this
…acquire-driver-common into 32-add-test-for-software-trigger
andy-sweet
reviewed
Aug 7, 2023
aliddell
approved these changes
Aug 7, 2023
nclack
commented
Aug 7, 2023
Comment on lines
+167
to
+175
| while (end == beg && is_running(runtime) && | ||
| clock_toc_ms(&t0) < test_timeout_ms) { | ||
| // delay so loop isn't busy polling | ||
| clock_sleep_ms(0, 10); | ||
| OK(acquire_map_read(runtime, 0, &beg, &end)); | ||
| } | ||
|
|
||
| if (end == beg && !is_running(runtime)) | ||
| break; |
There was a problem hiding this comment.
@andy-sweet I think the test is not flaky now.
I kept the sleep in the loop just so it's not burning CPU. I had to add the additional is_running check. Otherwise, there was a window where the acquisition would stop but it would make it to line 167 and hit the test timeout (and fail).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #32