Make metrics collection in throttle and middleware packages more flexible #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeYast
reviewed
Sep 5, 2024
| labels := reqInfo.makeLabels() | ||
| labels[httpRequestMetricsLabelStatusCode] = strconv.Itoa(status) | ||
| c.Durations.With(labels).Observe(time.Since(startTime).Seconds()) | ||
| func (pm *HTTPRequestPrometheusMetrics) IncInFlightRequests(requestInfo HTTPRequestInfoMetrics) { |
There was a problem hiding this comment.
Let's add header comments for public functions
| method string | ||
| routePattern string | ||
| userAgentType string | ||
| func (pm *HTTPRequestPrometheusMetrics) DecInFlightRequests(requestInfo HTTPRequestInfoMetrics) { |
There was a problem hiding this comment.
Let's add header comments for public functions
| // HTTPRequestInfoMetrics represents a request info for collecting metrics. | ||
| type HTTPRequestInfoMetrics struct { | ||
| Method string | ||
| RoutePattern string |
There was a problem hiding this comment.
Are we safe here due to the combinatorics of different HTTP routes?
There was a problem hiding this comment.
No, it's supposed to be the route pattern, not the final URL.
…ible Now middlewares receive interfaces instead of the concrete Prometheus implementations.
vasayxtx
force-pushed
the
throttle-metrics-collector
branch
from
4f031ed
to
0d21b9c
Compare
MikeYast
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now middlewares receive interfaces instead of the concrete Prometheus implementations.
This change is a breaking change. However, given the library’s current limited usage, we have decided not to bump the major version at this time.