Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve progress bars #181

Closed
3 tasks
dabreegster opened this issue May 19, 2023 · 1 comment · Fixed by #260
Closed
3 tasks

Improve progress bars #181

dabreegster opened this issue May 19, 2023 · 1 comment · Fixed by #260
Labels
good first issue Good for newcomers

Comments

@dabreegster
Copy link
Contributor

dabreegster commented May 19, 2023 •
edited
Loading

See #169 (comment). Starter in https://github.com/acteng/atip/tree/progress

  • Rewrite the fetchWithProgress in TS and use simpler HTML/CSS
  • Decide where to put the second progress bar for route info
  • Disable controls before the necessary data is ready?
@dabreegster dabreegster added the good first issue Good for newcomers label May 19, 2023
@dabreegster dabreegster mentioned this issue May 19, 2023
Merged
@Pete-Y-CS Pete-Y-CS linked a pull request Jul 5, 2023 that will close this issue
Make the route loading more obvious. #260
Merged
@dabreegster
Copy link
Contributor Author

Did a quick round of looking for NPM libraries that do the fetch...

anthumchris/fetch-progress-indicators#13 talks about Content-Length and gzipped files. We may be able to tell our webserver (S3+Cloudfront right now, equivalent GCP in the future) to set a custom header including the uncompressed size to expect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the route loading more obvious. acteng/atip
2 participants
@dabreegster @Pete-Y-CS